-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New command: m365 spe containertype add #5767
Comments
Generally, this looks alright @Adam-it but the option descriptions aren't very clear yet. I would suggest something like this:
A bit of clarification, looking at the documentation. Trial doesn't look like a type that should be used too often. That's why I removed the short for it and you won't submit this option with any value so One option that lacks clarity and lacks a well-documented explanation is |
Thanks @Jwaegebaert for your comments 👍.
|
@Jwaegebaert I aligned the spec according to your comment 👍 |
To the best of my knowledge, there's no limit on Azure region. Maybe there is with the public preview, but I haven't seen anything like that. The Azure subscription & resource group is only used because it's set up for metered billing whereas M365 is not. IOW, it's just a way for M365 to link to your CC |
Looks good @Adam-it. No further comments |
Nice work @Adam-it, only region is still lacking a bit of information but besides that, it looks good to go. |
Can I work on this? |
@MathijsVerbeeck, are you still working on this? |
Yes. I'm currently finalizing the response handling :) It takes quite some research as it's not really documented at the moment by Microsoft. |
@MathijsVerbeeck said
If you have trouble figuring something out, ping me... I'm doing a bunch of work with the SPE team and can lean on those resources if it helps. |
@MathijsVerbeeck sorry for the late update. |
Usage
m365 spe containertype add [options]
Description
Creates a new Container Type for your app
Options
-n, --name <name>
--applicationId <applicationId>
--trial
--azureSubscriptionId [azureSubscriptionId]
--resourceGroup [resourceGroup]
--region [region]
Examples
Adds a new trial container type
Default properties
No response
Additional Info
We may use CSOM for this command passing the following
we should add in command docs info or link to the docs explaining what is a trial container type and it's limits
https://learn.microsoft.com/en-us/sharepoint/dev/embedded/concepts/app-concepts/containertypes#sharepoint-embedded-trial-container-types
we should also provide a link to the container type docs https://learn.microsoft.com/en-us/sharepoint/dev/embedded/concepts/app-concepts/containertypes
expected output of the command should be something like
The text was updated successfully, but these errors were encountered: