-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edits to a custom category/playlist/Asset within Microsoft 365 Learning Pathways doesn't hide properly after its saved. #726
Comments
Hi @lamargardner565 , Thanks for reaching out to us. We will take a look at this and get back to you ! |
Thank you!
…________________________________
From: v-prigunasek ***@***.***>
Sent: Tuesday, March 28, 2023 11:21:40 AM
To: pnp/custom-learning-office-365 ***@***.***>
Cc: Lamar Gardner ***@***.***>; Mention ***@***.***>
Subject: Re: [pnp/custom-learning-office-365] Edits to a custom category/playlist/Asset within Microsoft 365 Learning Pathways doesn't hide properly after its saved. (Issue #726)
Hi @lamargardner565<https://github.com/lamargardner565> ,
Thanks for reaching out to us. We will take a look at this and get back to you !
—
Reply to this email directly, view it on GitHub<#726 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AZGSAXUW33I75EY4HV3VKOTW6L6YJANCNFSM6AAAAAAWJOLYB4>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Hi @dcashpeterson , I was able to reproduce the issue from my end. Whenever we edit an asset in a subcategory, the hidden subcategories become visible in the [Learning Pathways Viewer page] and we have to toggle the visibility button on the hidden subcategory to hide it again. Can you please confirm whether this is an expected behavior? Thanks! |
Yep, I can confirm this is a bug. The interim fix is to toggle the hide/show for just one category or playlist and that will fix all the settings. |
Thank you for the update. Is this bug getting worked on? Is there a time line when this will be fixed or is a new current solution being worked on. I am afraid that my customer wil loose all there content if this solution has to get re deployed for there environment. Any context is greatly appreciated.
|
Also, can you please confirm that this is for both content packs and non content packs witbh out of the box custom content categories?
|
@lamargardner565 It's not a great idea to respond to github notifications via email because it ends up embedding PII in the repository so I would avoid that in the future if I were you. I've edited your comments to remove it. The bug has been fixed, a PR has been issued, but has not been merged in. When it is this issue will automatically be closed so you will get a notification. I suspect it could happen next week at some point after it's reviewed. You do not loose data when you update a SharePoint Framework package, you just need to update it. |
Thank you for the update as in the future I will refrain from replying to all. Also, thank you for the update on the M365 LPs bug fix. Have a great day.
V/R
Lamar R. Gardner
Cloud Solution Architect – Engineering
Microsoft Federal | Business Applications
SharePoint | Dynamics 365 CRM
E: ***@***.******@***.***> | E: ***@***.******@***.***>
[Graphical user interface, application Description automatically generated]
From: Julie Turner ***@***.***>
Sent: Friday, March 31, 2023 10:53 AM
To: pnp/custom-learning-office-365 ***@***.***>
Cc: Lamar Gardner ***@***.***>; Mention ***@***.***>
Subject: Re: [pnp/custom-learning-office-365] Edits to a custom category/playlist/Asset within Microsoft 365 Learning Pathways doesn't hide properly after its saved. (Issue #726)
@lamargardner565<https://github.com/lamargardner565> It's not a great idea to respond to github notifications via email because it ends up embedding PII in the repository so I would avoid that in the future if I were you. I've edited your comments to remove it.
The bug has been fixed, a PR has been issued, but has not been merged in. When it is this issue will automatically be closed so you will get a notification. I suspect it could happen next week at some point after it's reviewed.
You do not loose data when you update a SharePoint Framework package, you just need to update it.
The update is for the base software, content packs have no baring on how it works and is unrelated.
—
Reply to this email directly, view it on GitHub<#726 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AZGSAXQIJ3RK5LB6IJEURMTW63VUHANCNFSM6AAAAAAWJOLYB4>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
|
Good morning,
I am checking in to see if there is a update on the this bug fix or maybe an approximate time when the final review will be completed?
V/R
Lamar R. Gardner
Cloud Solution Architect – Engineering
Microsoft Federal | Business Applications
SharePoint | Dynamics 365 CRM
E: ***@***.******@***.***> | E: ***@***.******@***.***>
[Graphical user interface, application Description automatically generated]
From: Julie Turner ***@***.***>
Sent: Friday, March 31, 2023 10:53 AM
To: pnp/custom-learning-office-365 ***@***.***>
Cc: Lamar Gardner ***@***.***>; Mention ***@***.***>
Subject: Re: [pnp/custom-learning-office-365] Edits to a custom category/playlist/Asset within Microsoft 365 Learning Pathways doesn't hide properly after its saved. (Issue #726)
@lamargardner565<https://github.com/lamargardner565> It's not a great idea to respond to github notifications via email because it ends up embedding PII in the repository so I would avoid that in the future if I were you. I've edited your comments to remove it.
The bug has been fixed, a PR has been issued, but has not been merged in. When it is this issue will automatically be closed so you will get a notification. I suspect it could happen next week at some point after it's reviewed.
You do not loose data when you update a SharePoint Framework package, you just need to update it.
The update is for the base software, content packs have no baring on how it works and is unrelated.
—
Reply to this email directly, view it on GitHub<#726 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AZGSAXQIJ3RK5LB6IJEURMTW63VUHANCNFSM6AAAAAAWJOLYB4>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
|
@lamargardner565 my apologies. I am the bottleneck here on the merge. I've been tied up with client work. I will get this merged in the next week or so. |
Good morning and no worries. Thank you for the update.
V/R
Lamar R. Gardner
Cloud Solution Architect – Engineering
Microsoft Federal | Business Applications
SharePoint | Dynamics 365 CRM
E: ***@***.******@***.***> | E: ***@***.******@***.***>
[Graphical user interface, application Description automatically generated]
From: Derek Cash-Peterson ***@***.***>
Sent: Tuesday, April 18, 2023 6:01 AM
To: pnp/custom-learning-office-365 ***@***.***>
Cc: Lamar Gardner ***@***.***>; Mention ***@***.***>
Subject: Re: [pnp/custom-learning-office-365] Edits to a custom category/playlist/Asset within Microsoft 365 Learning Pathways doesn't hide properly after its saved. (Issue #726)
@lamargardner565<https://github.com/lamargardner565> my apologies. I am the bottleneck here on the merge. I've been tied up with client work. I will get this merged in the next week or so.
—
Reply to this email directly, view it on GitHub<#726 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AZGSAXWQA5UEB7FUN2S6UNDXBZQ5HANCNFSM6AAAAAAWJOLYB4>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
|
@lamargardner565 I have merged in the fix for this. You can update your package to the latest version. |
Thank you for this update. I will test this.
V/R
Lamar R. Gardner
Cloud Solution Architect – Engineering
Microsoft Federal | Business Applications
SharePoint | Dynamics 365 CRM
E: ***@***.******@***.***> | E: ***@***.******@***.***>
[Graphical user interface, application Description automatically generated]
From: Derek Cash-Peterson ***@***.***>
Sent: Thursday, April 20, 2023 9:45 AM
To: pnp/custom-learning-office-365 ***@***.***>
Cc: Lamar Gardner ***@***.***>; Mention ***@***.***>
Subject: Re: [pnp/custom-learning-office-365] Edits to a custom category/playlist/Asset within Microsoft 365 Learning Pathways doesn't hide properly after its saved. (Issue #726)
@lamargardner565<https://github.com/lamargardner565> I have merged in the fix for this. You can update your package to the latest version.
—
Reply to this email directly, view it on GitHub<#726 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AZGSAXT2XCC45DKBKPIELKTXCE4UZANCNFSM6AAAAAAWJOLYB4>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
|
This issue is locked for inactivity or age. If you have a related issue please open a new issue and reference this one. Closed issues are not tracked. |
ISSUE:
Editing an Asset within LP site causes all LP content to be viewable to all users, regardless of view settings.
DESCRIPTION:
When a playlist is edited within the LP site, once the asset is saved, all tiles in the MS Learning Pathways solution is viewable to site visitors, even where many of those assets should be hidden.
APP DETAILS:
Microsoft 365 Learning Pathways version 4.3.1.0, release date February 2023
STEPS TO REPRODUCE:
WORKAROUND:
Additional context
Can you please provide context to why this is happening? Is this normal behavior?
The text was updated successfully, but these errors were encountered: