Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edits to a custom category/playlist/Asset within Microsoft 365 Learning Pathways doesn't hide properly after its saved. #726

Closed
lamargardner565 opened this issue Mar 27, 2023 · 14 comments
Labels
area: SPFx Issue with SPFx, not web part directly auto-locked status: fixed type: bug Something isn't working

Comments

@lamargardner565
Copy link

ISSUE:
Editing an Asset within LP site causes all LP content to be viewable to all users, regardless of view settings.

DESCRIPTION:
When a playlist is edited within the LP site, once the asset is saved, all tiles in the MS Learning Pathways solution is viewable to site visitors, even where many of those assets should be hidden.

APP DETAILS:
Microsoft 365 Learning Pathways version 4.3.1.0, release date February 2023

image

STEPS TO REPRODUCE:

  1. Ensure the LP Home page, or [Learning Pathways Viewer page], is displaying the correct tiles

image

  1. Navigate to the [CustomLearningAdmin]) Page in LP, select a subcategory and select a Playlist within that subcategory

image

  1. Scroll down to Playlist Assets and make a change and revert (in order to trigger/unghost the Save Asset button). In the example below, I changed “Teams” to “Teamz” and back to “Teams” to allow a new save, just for testing. Note that any change/addition/deletion, whether reverted or kept, will introduce this issue.

image

  1. Navigate back to the Home/HUB page, or [Learning Pathways Viewer page], and note the web part now displays ALL content, even though the admin page indicates they should be hidden.

image

WORKAROUND:

  1. To remediate this issue, navigate to the [Customer Learning Admin] page in LP and toggle the visibility of a subcategory to trigger the admin page to auto save. Note this is not a viable workaround solution, as customers will be able to view all hidden content until they reload the page.

image

  1. The Home tiles then display the correct viewable content:

image

Additional context

Add any other context about the problem here.

Can you please provide context to why this is happening? Is this normal behavior?

@v-prigunasek
Copy link

Hi @lamargardner565 ,

Thanks for reaching out to us. We will take a look at this and get back to you !

@lamargardner565
Copy link
Author

lamargardner565 commented Mar 28, 2023 via email

@v-prigunasek
Copy link

Hi @dcashpeterson ,

I was able to reproduce the issue from my end. Whenever we edit an asset in a subcategory, the hidden subcategories become visible in the [Learning Pathways Viewer page] and we have to toggle the visibility button on the hidden subcategory to hide it again. Can you please confirm whether this is an expected behavior? Thanks!

@juliemturner
Copy link
Contributor

Yep, I can confirm this is a bug. The interim fix is to toggle the hide/show for just one category or playlist and that will fix all the settings.

@lamargardner565
Copy link
Author

lamargardner565 commented Mar 30, 2023 via email

@lamargardner565
Copy link
Author

lamargardner565 commented Mar 30, 2023 via email

@juliemturner
Copy link
Contributor

@lamargardner565 It's not a great idea to respond to github notifications via email because it ends up embedding PII in the repository so I would avoid that in the future if I were you. I've edited your comments to remove it.

The bug has been fixed, a PR has been issued, but has not been merged in. When it is this issue will automatically be closed so you will get a notification. I suspect it could happen next week at some point after it's reviewed.

You do not loose data when you update a SharePoint Framework package, you just need to update it.
The update is for the base software, content packs have no baring on how it works and is unrelated.

@lamargardner565
Copy link
Author

lamargardner565 commented Mar 31, 2023 via email

@lamargardner565
Copy link
Author

lamargardner565 commented Apr 17, 2023 via email

@dcashpeterson
Copy link
Contributor

@lamargardner565 my apologies. I am the bottleneck here on the merge. I've been tied up with client work. I will get this merged in the next week or so.

@lamargardner565
Copy link
Author

lamargardner565 commented Apr 18, 2023 via email

@dcashpeterson
Copy link
Contributor

@lamargardner565 I have merged in the fix for this. You can update your package to the latest version.

@lamargardner565
Copy link
Author

lamargardner565 commented Apr 20, 2023 via email

@github-actions
Copy link

This issue is locked for inactivity or age. If you have a related issue please open a new issue and reference this one. Closed issues are not tracked.

@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: SPFx Issue with SPFx, not web part directly auto-locked status: fixed type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants