Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added functionalities to list replies of a teams chat message and add new replies #853

Merged
merged 4 commits into from
May 20, 2022

Conversation

MathijsVerbeeck
Copy link
Contributor

Issue ref: #310

@jansenbe I'll try my best and write documentation for this feature + the other latest features regarding Team Events + Team Chat mentioning later this week.

@jansenbe
Copy link
Contributor

Thanks again for the help!

@MathijsVerbeeck
Copy link
Contributor Author

@jansenbe I've added batching functionalities.

I noticed that sometimes, when having a channel with in my case +- 170 messages, the message that I've just added will not be retrieved when just "running" the test. To make the tests work, I have to add a breakpoint on the getting of the messages and continue and the newly created message will be found. If you can't reproduce this issue or still have questions due to my explanation being kinda "vague", don't hesitate to contact me 😄

@jansenbe jansenbe self-assigned this May 20, 2022
@jansenbe jansenbe added the area: model 📐 Related to the core SDK models label May 20, 2022
jansenbe added a commit that referenced this pull request May 20, 2022
@jansenbe jansenbe merged commit 4506bc0 into pnp:dev May 20, 2022
@MathijsVerbeeck MathijsVerbeeck deleted the replytomessage branch September 22, 2022 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: model 📐 Related to the core SDK models
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants