Skip to content

Conversation

reshmee011
Copy link
Contributor

Before creating a pull request, make sure that you have read the contribution file located at

https://github.com/pnp/powerShell/blob/dev/CONTRIBUTING.md

Type

  • Bug Fix
  • New Feature
  • Sample

Related Issues?

Fixes #X, partially fixes #Y, mentioned in #Z, etc.

What is in this Pull Request ?

Please describe the changes in the PR.

Guidance

  • You can delete this section when you are submitting the pull request.*
  • Please update this PR information accordingly. We use this as part of our release notes in monthly communications.
  • Please target your PR to Dev branch. If you do not target the Dev branch we will not accept this PR.

Summary

copilot:summary

Details

copilot:walkthrough

@gautamdsheth
Copy link
Collaborator

hi @reshmee011 , do we need this as a separate cmdlet ?
We support it via Set-PnPSite -ScriptSafeDomainName.

I looked the the Set-PnPSite code , so maybe we can improve it with your code which is a better implementation.

Curious to hear your thoughts :)

@reshmee011
Copy link
Contributor Author

@gautamdsheth : True, we can use the existing cmdlet. I will look into amending it then.

@reshmee011
Copy link
Contributor Author

@gautamdsheth : I merged the code into set-pnpsite, awesome review. I missed it within set-pnpsite when I submitted it.

@gautamdsheth gautamdsheth merged commit 91b1c84 into pnp:dev May 4, 2023
@gautamdsheth
Copy link
Collaborator

Thanks @reshmee011 , merged it !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants