Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💡 [Feature]: Improve sample/scenario gallery #126

Closed
2 tasks done
Adam-it opened this issue Oct 28, 2023 · 2 comments · Fixed by #154
Closed
2 tasks done

💡 [Feature]: Improve sample/scenario gallery #126

Adam-it opened this issue Oct 28, 2023 · 2 comments · Fixed by #154
Assignees
@Adam-it
Labels
⭐ enhancement New feature or request 👨‍💻work in progress I am working on it
Milestone
v3.0

Comments

@Adam-it
Copy link
Contributor

Adam-it commented Oct 28, 2023 •
edited
Loading

🎯 Aim of the feature

We could refactor it to the following way:

  • first of all currently we have 4 separate galleries. Why not make it a single gallery view with filters to filter out webpart/extesion/ACE.
  • also the view could provide a detail page so that the user won't be redirected outside of VS Code
@Adam-it Adam-it added ⭐ enhancement New feature or request ✏️prototype labels Oct 28, 2023
@Adam-it Adam-it added this to the v3.0 milestone Oct 28, 2023
@Adam-it
Copy link
Contributor Author

Adam-it commented Dec 3, 2023 •
edited
Loading

other ideas:

  • consider more ways of filtering the sample by author, description, title, type
  • we should have an alternative view to show more items in a view

@Adam-it
Copy link
Contributor Author

Adam-it commented Dec 3, 2023 •
edited
Loading

  • the tags should be below title
  • the buttons are not visible and should not be just icons but actual buttons
  • do we need pagination?
    image

@Adam-it Adam-it added 👨‍💻work in progress I am working on it and removed ✏️prototype labels Dec 3, 2023
@Adam-it Adam-it self-assigned this Dec 3, 2023
@Adam-it Adam-it mentioned this issue Dec 29, 2023
Merged
7 tasks
@Adam-it Adam-it linked a pull request Dec 29, 2023 that will close this issue
Improves sample view. Closes: #126 #154
Merged
7 tasks
Adam-it added a commit that referenced this issue Dec 29, 2023
@Adam-it
Improves sample view. Closes: #126 (#154)
4937915 
## 🎯 Aim

The is to refactor the sample view to merge all samples to a single view
that allows filtering and detail view.

## 📷 Result


![image](https://github.com/pnp/vscode-viva/assets/58668583/0f5baac3-4d59-4ce2-b216-8ca8eef99885)


![image](https://github.com/pnp/vscode-viva/assets/58668583/9e6b0c00-296c-46a7-a159-88a76fa19776)

## ✅ What was done

- [X] Refactors welcome experience
- [X] Adds filters
- [X] Adds details view
- [X] Adds list view of rows as and alternative to card view
- [X] Rebuilds card view
- [X] Unifies samples
- [X] Adds counter

## 🔗 Related issue

Closes: #126
@Adam-it Adam-it closed this as completed Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Adam-it Adam-it

Labels
⭐ enhancement New feature or request 👨‍💻work in progress I am working on it
Projects
None yet
Milestone
v3.0
Development

Successfully merging a pull request may close this issue.

Improves sample view. Closes: #126
1 participant
@Adam-it