Updates terminal usage to use TerminalCommandExecuter service. Closes: #246 #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Saurabh7019 since you are the author of the original issue and are aware how to locally build and debug the VS Code extension and since now the only person that had this issue 😉, may I kindly ask you double check this fix and if now you see |
|
Hi @Adam-it , I just verified it, and it works fine now. I apologize for not being able to check it sooner. |
No problem 👍 |
|
ready to merge 🚀 |
Adam-it
added a commit
that referenced
this pull request
Aug 6, 2024
…#246 (#280) ## 🎯 Aim The aim is to refactor the way start and run commands in integrated VS Code terminal. The idea is to aling the approach by using the dedicated Terminal service which was developed for exactly that. ## ✅ What was done - [X] Removes all direct usage of `terminal` and refactors it to same approach ## 🔗 Related issue Closes: #246
Adam-it
added a commit
that referenced
this pull request
Sep 8, 2024
…#246 (#280) ## 🎯 Aim The aim is to refactor the way start and run commands in integrated VS Code terminal. The idea is to aling the approach by using the dedicated Terminal service which was developed for exactly that. ## ✅ What was done - [X] Removes all direct usage of `terminal` and refactors it to same approach ## 🔗 Related issue Closes: #246
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Aim
The aim is to refactor the way start and run commands in integrated VS Code terminal. The idea is to aling the approach by using the dedicated Terminal service which was developed for exactly that.
✅ What was done
terminaland refactors it to same approach🔗 Related issue
Closes: #246