Skip to content
This repository has been archived by the owner on Jun 29, 2020. It is now read-only.

(Refactor) some variable declarations were be avoided. Readability and gas costs were improved #117

Merged

Conversation

Janther
Copy link
Contributor

@Janther Janther commented Apr 23, 2018

  • What is it? (leave one option)

    • (Refactor) of existing code (no functionality change)
  • What feature was missing?

Cleaning up the code before having it in production.

  • How does this pull request solve it (in broad terms)?

Refactor of a decreasing for statement.
Removal of a variable declaration that was only used once in unregisterAddress().

  • Quick checklist

    • npm run lint shows no errors
    • docs were updated where necessary OR they don't need to be updated
    • tests were updated where necessary OR they don't need to be updated
  • Additional information

Also, some standardization in some statements was performed.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 369

  • 4 of 11 (36.36%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 74.301%

Changes Missing Coverage Covered Lines Changed/Added Lines %
blockchain/contracts/ProofOfPhysicalAddress.sol 4 11 36.36%
Files with Coverage Reduction New Missed Lines %
blockchain/contracts/ProofOfPhysicalAddress.sol 1 47.03%
Totals Coverage Status
Change from base Build 366: 0.05%
Covered Lines: 875
Relevant Lines: 1128

💛 - Coveralls

@phahulin phahulin merged commit 43b6edf into poanetwork:master Apr 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants