Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Feature) add source code of Proxy smart-contract to Publish page #1115

Merged
merged 5 commits into from
Aug 31, 2018

Conversation

fernandomg
Copy link
Contributor

Closes #1037

I've just added sources for .abi, .bin and .src.

@dennis00010011b
Copy link

@fernandomg
Publish page: section CROWDSALE PROXY CONTRACT CREATION CODE contains contract byte code (it matches ./public/contracts/MintedCappedProxy.bin in case of Minted crowdsale)

Should contains contract creation code = contract byte code + constructor parameters

@coveralls
Copy link

coveralls commented Aug 28, 2018

Pull Request Test Coverage Report for Build 2980

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 20.332%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/stepFour/index.js 0 1 0.0%
Totals Coverage Status
Change from base Build 2976: -0.02%
Covered Lines: 834
Relevant Lines: 3595

💛 - Coveralls

@fernandomg
Copy link
Contributor Author

@dennis00010011b Mh... It was intended to be the 'Contract Creation Code' for the proxy contract. And so far it looks that it's not necessary on the TW.

Also to find the 'Contract Creation Code' for an already deployed contract, I have to find the original tx when the Proxy contract was deployed, and gather the information from there (@dennis00010011b, @vbaranov please correct me if I'm wrong).

So I just leave only the .abi and .src content in the Publish page.

@vbaranov
Copy link
Collaborator

@fernandomg we need to give source code and ABI encoded parameters to a user. By having these set of parameters (with contract name and compiler version) a user will be able to verify Proxy smart-contract and will see ABI of it after verification. Addition of ABI encoded parameters is requested in #1038. Addition of source code is implemented here. Display of ABI is redundant. Let's remove it from Publish page.

@fernandomg
Copy link
Contributor Author

@vbaranov thanks for the clarification, change done.

@vbaranov vbaranov merged commit 0034ba4 into 2.0 Aug 31, 2018
@ghost ghost removed the awaiting for review label Aug 31, 2018
@vbaranov vbaranov deleted the add-proxy-sourceCode-#1037 branch August 31, 2018 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants