(Fix) Update DApp loading code considering upcoming Breaking Change in MetaMask (Branch Master) #1171
Conversation
mariano-aguero
requested review from
fernandomg,
vbaranov and
dennis00010011b
Pull Request Test Coverage Report for Build 3263
💛 - Coveralls |
There was a problem hiding this comment.
@mariano-aguero
Manage page isn't fully rendered unless clicking button 'Finalize'
Steps:
- Create crowdsale: Minted, 1 tier, no whitelist
- Open Manage page, observe(see screenshot)
- Click button 'Finalize'-page is rendered after that
mariano-aguero
changed the title
|
Double dots: and let's change the link to Token Wizard wiki |
Done! |
It is not an error related to the changes made it, anyway I solved in this branch Regards |
|
Do not merge until @fernandomg do the code review |
There was a problem hiding this comment.
@mariano-aguero
Everything is working fine, but there are a couple of things that I'm not completely sure about.
src/react-web3/Web3Provider.js
Outdated
| this.setState({ | ||
| web3: window.web3 | ||
| }) | ||
| this.fetchAccounts() |
There was a problem hiding this comment.
Here fetchAccounts is being called, but it's called aswell inside the interval defined in the line 91, which is called after calling checkWeb3, in the line 40
There was a problem hiding this comment.
Removed the interval
mariano-aguero
force-pushed
the
issue#1165
branch
from
417646f
to
f83600b
Compare
src/react-web3/Web3Provider.js
Outdated
| this.setState({ | ||
| approvePermissions: false | ||
| }) | ||
| console.log(err.message) |
There was a problem hiding this comment.
@fernandomg
If my memory doesn't fail me, logger is used in the branch 2.0, please correct me if I'm wrong
Greetings
|
I can't get "MetaMask not found" error page with local build. As a result app crashed on Step 2.
|
Fixed |
ghost
removed
the
Closes #1165 .
Modify the "MetaMask not found" error page to display a generic error text stating "Wallet not found, or access to Ethereum account not granted"
This is for the master branch, there will be another PR for the branch 2.0