Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Fix) xDai missing in warning message #1194

Conversation

fernandomg
Copy link
Contributor

Closes #1192

xDai was added as one of the known networks in the TW

@dennis00010011b
Copy link

@fernandomg
'xDai' instead 'XDai' ?

screen shot 2018-10-22 at 4 55 03 pm

poanetwork/nifty-wallet#153 (comment)

@ghost ghost assigned mariano-aguero Oct 23, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3355

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 31 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 18.896%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/utils/blockchainHelpers.js 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
src/components/crowdsale/utils.js 31 3.46%
Totals Coverage Status
Change from base Build 3346: -0.02%
Covered Lines: 893
Relevant Lines: 4041

💛 - Coveralls

@mariano-aguero mariano-aguero merged commit 5bd2c06 into 2.0 Oct 23, 2018
@ghost ghost removed the awaiting for review label Oct 23, 2018
@mariano-aguero mariano-aguero deleted the 1192-bug-incorrect-warnings-text-if-change-network-while-deployment branch October 23, 2018 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants