(Fix) Set deploymentStep when starting step four #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Pull Request Test Coverage Report for Build 1593
💛 - Coveralls |
fernandomg
approved these changes
Mar 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #593 (the underlying issue).
Switching networks may cause a lot of issues, and I'm not sure we can (or should) fix them all. For example, if you switch networks in the middle of a deployment, you'll be allowed to continue, but the deploy will of course fail.
I guess we could save the id of the network where the deployment started, and alert the user that they are in a different network. But I wouldn't try anything more clever than that (for example, persisting different incomplete deployments in the local storage according to the network that is being used).