-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Fix) e2e tests with current changes on local deployment in Travis CI #698
Conversation
Pull Request Test Coverage Report for Build 1715
💛 - Coveralls |
.travis.yml
Outdated
@@ -6,7 +6,6 @@ install: | |||
- npm install | |||
|
|||
before_script: | |||
- npm run installWeb3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may break the unit tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, this will work because npm test
runs the e2e tests first, and the e2e-prepare-start
script installs web3. This makes the tests order-dependent, but it's not a big deal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fvictorio you are right. It is better to leave in .travis.yml. I'll redefine e2e-prepare-start
script instead.
@dennis00010011b please let us know when e2e tests will be fixed. Then we will be able to merge this PR. And after it, e2e tests will be launching on the version of Wizard in PR, not on production link. |
Relates to poanetwork/token-wizard-test-automation#17
e2e tests with current changes on local deployment in Travis CI