Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add macos sanitizer CI jobs #4313

Closed
aleks-f opened this issue Nov 28, 2023 · 2 comments · Fixed by #4346
Closed

Add macos sanitizer CI jobs #4313

aleks-f opened this issue Nov 28, 2023 · 2 comments · Fixed by #4346
Assignees
@matejk
Labels
CI Continuous Integration fixed
Milestone
Release 1.13.1

Comments

@aleks-f
Copy link
Member

aleks-f commented Nov 28, 2023

as stated - looks like g++ sanitizers do not report everything
@aleks-f aleks-f added the CI Continuous Integration label Nov 28, 2023
@aleks-f aleks-f added this to the Release 1.13.0 milestone Nov 28, 2023
@matejk
Copy link
Contributor

matejk commented Dec 7, 2023

@aleks-f, would is also make sense to run sanitizers with clang++ on Linux?

@aleks-f
Copy link
Member Author

aleks-f commented Dec 7, 2023

@aleks-f, would is also make sense to run sanitizers with clang++ on Linux?

It would, but then there is the factor of the github CI environment, timeouts, and completion times. Perhaps one day, when we have our own CI infrastructure that we control and can scale accordingly.

matejk added a commit that referenced this issue Dec 8, 2023
@matejk
enh(ci): Add macos sanitizers job (#4313)
f840819
matejk added a commit that referenced this issue Dec 8, 2023
@matejk
enh(ci): Add macos sanitizers job (#4313)
427b985
matejk added a commit that referenced this issue Dec 15, 2023
@matejk
enh(ci): Add macos sanitizers job (#4313)
362e667
matejk added a commit that referenced this issue Dec 15, 2023
@matejk
enh(ci): Add macos sanitizers job (#4313)
f1cc19a
@matejk matejk mentioned this issue Dec 15, 2023
Merged
matejk added a commit that referenced this issue Dec 15, 2023
@matejk
enh(ci): Add macos sanitizers job (#4313)
c882c9c
@matejk matejk modified the milestones: Release 1.13.0, Release 1.13.1 Dec 15, 2023
matejk added a commit that referenced this issue Dec 22, 2023
@matejk
enh(ci): Add macos sanitizers job (#4313)
043f89c
matejk added a commit that referenced this issue Jan 3, 2024
@matejk
enh(ci): Add macos sanitizers job (#4313)
ae3930b
matejk added a commit that referenced this issue Jan 3, 2024
@matejk
fix(test): lock std:cerr to prevent data race in TCP server tests (re…
ec8dd05 
…ported by clang thread sanitizer) #4313
@matejk matejk linked a pull request Jan 3, 2024 that will close this issue
macOS sanitizer github jobs (fixes #4313) #4346
Merged
matejk added a commit that referenced this issue Jan 5, 2024
@matejk
enh(ci): Add macos sanitizers job (#4313)
b48d42d
matejk added a commit that referenced this issue Jan 5, 2024
@matejk
fix(test): lock std:cerr to prevent data race in TCP server tests (re…
ab3582d 
…ported by clang thread sanitizer) #4313
matejk added a commit that referenced this issue Jan 5, 2024
@matejk
enh(ci): Add macos sanitizers job (#4313)
38b2f2f
matejk added a commit that referenced this issue Jan 5, 2024
@matejk
fix(test): lock std:cerr to prevent data race in TCP server tests (re…
287befc 
…ported by clang thread sanitizer) #4313
matejk added a commit that referenced this issue Jan 7, 2024
@matejk
enh(ci): Add macos sanitizers job (#4313)
4467416
matejk added a commit that referenced this issue Jan 7, 2024
@matejk
fix(test): lock std:cerr to prevent data race in TCP server tests (re…
db63550 
…ported by clang thread sanitizer) #4313
@matejk matejk added the fixed label Jan 8, 2024
aleks-f added a commit that referenced this issue Feb 6, 2024
@aleks-f @obiltschnig
@matejk @jspricke @jackorobot @thebearon @andrewauclair
Release 1.13.1 (#4373)
6d17354 
* doc(ReleaseNotes): fix formatting, add PR links

* Incorporated Debian patches (#4380)

* Debian: Use null as device file as console might not be there

* Debian: Add GNU Hurd support

* Debian: Includes not available on Hurd

* Debian: Disable SHA2 test on platforms where it's broken

* Debian: Set POCO_NO_FPENVIRONMENT for armel

---------

Co-authored-by: Jochen Sprickerhof <git@jochen.sprickerhof.de>

* fix(UUID): UUID parser silently ignores too long strings #4375 (#4384)

* fix(Crypto): EVP_CIPHER_CTX_init is incorrectly defined in Envelope.cpp if it is not defined already by OpenSSL. Fixed to properly use EVP_CIPHER_CTX_reset.

* enh(ci): Add macos sanitizers job (#4313)

* enh(ci): macOS thread sanitizer

* enh(ci): macOS sanitize jobs for undefined and address.

* fix(test): lock std:cerr to prevent data race in TCP server tests (reported by clang thread sanitizer) #4313

* fix(test): Use 96-bit IV with aes-256-gcm to fix (#4347):

I/O error: error:1C800066:Provider routines::cipher operation failed

* mingw compile and link improvements (#4019) (#4391)

* fix(platform): MinGW Compile and link errors: undefined reference to `WinMain'

* fix(platform): MinGW compile UUID tests (conflicting UUID defined as GUID in rpcdce.h via windows.h)

* enh(DateTimeParser): option to cleanup input string before parsing (#569).

* fix(CppUnit): do not install #4398

* fix(DataTest): do not install #4398

* chore(SingleSocketPoller): spelling

* fix(MailMessage): Compare lowercase content disposition headers when reading parts (#3650).

* chore(cmake): CppUnit Foundation dependency documentation; fix indentation

* fix(SocketReactorTest): deadlock test intermittently hangs #4400

* gcc/clang (-fvisibility=hidden): corrections to compile and work properly (#4394)

* fix(ActiveRecord): missing ActiveRecordLib_API definitions for clang/gcc.

* fix(FPEnvironment): export FPEnvironmentImpl classes (#4393, #3331)

* fix(Crypto): export *Impl classes used from inlines (#4393, #3331)

* fix(Dynamic): explicitly instantiate and export Dynamic::Struct for string and int (-fvisibility=hidden) (#4393, #3331)

* fix(JSON): explicitly instantiate and export SharedPtr for JSON::Array and JSON::Object (-fvisibility=hidden) (#4393, #3331)

* enh(CMake): Set symbol visibility to hidden (#4393, #3331)

* enh(configure): user c++17 standard for iphone, Darwin and ARM-Linux.

* fix(UTF): explicitly instantiate and export 16 and 32-bit strings (-fvisibility=hidden) (#4393, #3331)

* fix(RecordSet): make Extraction.h internal and instantiate RecordsSet::column template functions only for supported types. (-fvisibility=hidden) (#4393, #3331)

* fix(UTF): fix explicitly instantiation on Windows (-fvisibility=hidden) (#4393, #3331)

* enh(CMake): Add github jobs for macOS with visibility set to hidden (#4393, #3331)

* fix(CppParser): Add missing declarations for CppParser_API (#4393, #3331)

* enh(CMake): Enable more options in github jobs for macOS with visibility set to hidden (#4393, #3331)

* fix(MongoDB): Add missing MongoDB_API (#4393, #3331)

* Implemented automated network library initialization for Windows MinGW targets (#4402)

* Implemented automated network library initialization for Windows MinGW/GCC targets

* Using POCO_COMPILER_MINGW instead of __GNUC__

---------

Co-authored-by: Jesse Hoogervorst <jesse@deltaxlab.com>

* fix(Thread_POSIX): qnx build error: 'prctl' was not declared in this scope #4404

* fix: NULL pointer strategy when setting rotation never #4411

Regression from 66e93f9.

* fix(progen): add LanguageStandard (stdcpp17, stdc11); regenerate vs170 projects

* Implement GetAdaptersAddresses API (#4419)

* Upgrade from GetAdaptersInfo to GetAdaptersAddresses API. The code has been swapped back to a buffer of bytes because the data structure built by GetAdaptersAddresses is a linked list and the returned size is not a multiple of the IP_ADAPTERS_ADDRESSES struct.

* Adding back Poco/UnWindows.h

* Undoing indents.

* test(ThreadPool): unit test for thread pool shutdown when no worker is running. (#2450)

* enh: #4216: use std::string literals

* enh: #3890: Get rid of SingletonHolder

* enh(File): Linux, macOS: microsecond precision for file times (create and modification time).

* enh(tests): Ability to enable/disable testing of deprecated functionality. (#4425)

* fix(SSLManager): Fixed regression introduced in PR #4103, fixes #4421

* fix(LogFile): Unify flushing behaviour of WIN32 and STD implementation (#2443)

* chore(buildwin): remove old vs versions from build and progen scripts; update documentation

* chore(buildwin): remove leftover closing curly

* enh(SQLite): SQLite FTS5 #4367

* Release 1.13.1: Update release notes, changelog, contributors, version files. (#4440)

* Update CONTRIBUTORS

* fix(CppParser): Documentation generation (some minor fixes, WiP) #4441

* feat(CppParser): C++11 attributes support

* feat(PocoDoc): C++11 attributes support

* chore(doc): Changelog and release notes formatting

* fix(CppParser): parsing of function template parameters and namespace imports

* fix: make headers parseable by CppParser/PocoDoc

* fix(PocoDoc): add -DPOCO_DOC

* fix(PocoDoc): postgres headers not found

* fix(PocoDoc): libpq include path

* fix(XML): #4443: Upgrade libexpat to 2.6.0

* doc: updated changelog

---------

Co-authored-by: Günter Obiltschnig <guenter.obiltschnig@appinf.com>
Co-authored-by: Matej Kenda <matejken@gmail.com>
Co-authored-by: Jochen Sprickerhof <git@jochen.sprickerhof.de>
Co-authored-by: Jesse Hoogervorst <hoogervorstjesse@gmail.com>
Co-authored-by: Jesse Hoogervorst <jesse@deltaxlab.com>
Co-authored-by: Aron Budea <aron.budea@collabora.com>
Co-authored-by: Andrew Auclair <andrewauclair@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matejk matejk

Labels
CI Continuous Integration fixed
Projects
None yet
Milestone
Release 1.13.1
Development

Successfully merging a pull request may close this issue.

macOS sanitizer github jobs (fixes #4313) pocoproject/poco
2 participants
@matejk @aleks-f