Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning sign compare #2960

Merged
merged 1 commit into from
Jun 21, 2022

Commits on Mar 19, 2020

  1. Fix some clang 10 -Wsign-compare warnings

    In file included from /data/mwrep/res/osp/Poco/JSON/20-0-0-0/include/Poco/JSON/Object.h:22:
    In file included from /data/mwrep/res/osp/Poco/JSON/20-0-0-0/include/Poco/JSON/Array.h:23:
    In file included from /data/mwrep/res/osp/Poco/Foundation/20-0-0-0/include/Poco/Dynamic/Var.h:26:
    In file included from /data/mwrep/res/osp/Poco/Foundation/20-0-0-0/include/Poco/Dynamic/VarHolder.h:22:
    In file included from /data/mwrep/res/osp/Poco/Foundation/20-0-0-0/include/Poco/NumberFormatter.h:22:
    /data/mwrep/res/osp/Poco/Foundation/20-0-0-0/include/Poco/NumericString.h:220:31: error: comparison of integers of different signs: 'unsigned long' and 'char' [-Werror,-Wsign-compare]
                                    if ((limitCheck - result) < add) return false;
                                         ~~~~~~~~~~~~~~~~~~~  ^ ~~~
    /data/mwrep/res/osp/Poco/Foundation/20-0-0-0/include/Poco/NumericString.h:229:31: error: comparison of integers of different signs: 'unsigned long' and 'char' [-Werror,-Wsign-compare]
                                    if ((limitCheck - result) < add) return false;
                                         ~~~~~~~~~~~~~~~~~~~  ^ ~~~
    /data/mwrep/res/osp/Poco/Foundation/20-0-0-0/include/Poco/NumericString.h:240:31: error: comparison of integers of different signs: 'unsigned long' and 'char' [-Werror,-Wsign-compare]
                                    if ((limitCheck - result) < add) return false;
                                         ~~~~~~~~~~~~~~~~~~~  ^ ~~~
    /data/mwrep/res/osp/Poco/Foundation/20-0-0-0/include/Poco/NumericString.h:249:31: error: comparison of integers of different signs: 'unsigned long' and 'char' [-Werror,-Wsign-compare]
                                    if ((limitCheck - result) < add) return false;
                                         ~~~~~~~~~~~~~~~~~~~  ^ ~~~
    4 errors generated.
    Romain-Geissler-1A committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    9c0ebc0 View commit details
    Browse the repository at this point in the history