Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/issue-14: Handle case when granules from the same collection have different variables #16

Merged
merged 6 commits into from
Feb 14, 2022

Conversation

skorper
Copy link
Contributor

@skorper skorper commented Feb 11, 2022

Github Issue: #14

Description

Handle case when granules from the same collection have different variables

Overview of work done

Some collections contain granules with inconsistent variables. For example, MODIS_T-JPL-L2P-v2019.0 has day/night granules where the variables differ. This causes failures in Concise, which expects the variables to be the same.

With this update, Concise will use empty data for a particular subset_index where the data was not present.

Overview of verification done

Created a new unit test using a day and night granule from MODIS_T-JPL-L2P-v2019.0

Overview of integration done

N/A

PR checklist:

  • Linted
  • Updated unit tests
  • Updated changelog
  • Integration testing

See Pull Request Review Checklist for pointers on reviewing this pull request

@skorper skorper merged commit f35e1b8 into develop Feb 14, 2022
@skorper skorper deleted the feature/issue-14 branch February 14, 2022 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants