Feature/issue harmony 1189 - update harmony-service-lib-py version #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I could not for the life of me figure out how to run the github action workflow on the fork so I pushed commit 7a85ac4 to a new branch in podaac/concise and ran the workflow on that branch |
frankinspace
approved these changes
Jul 19, 2022
|
Thanks Frank! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Issue: #harmony-1189
#34
Description
This updates the version of the harmony service library dependency. This is necessary because the service library was updated to be able to read/write STAC catalogs from S3 (https://github.com/nasa/harmony-service-lib-py/releases/tag/v1.0.20). Before merging in the corresponding Harmony code (nasa/harmony#224), we need to update all services to use the new service library version since the STAC catalogs written by Harmony and passed to the services will now be in S3.
Overview of work done
Updated harmony-service-lib-py version to
1.0.20.Overview of verification done
I'm having trouble running the tests without errors. I keep seeing:
Overview of integration done
There is a bug in Harmony at the moment that's preventing me from running a local integration test. I will try to test when that's resolved.
PR checklist:
See Pull Request Review Checklist for pointers on reviewing this pull request