Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/podaac 4658 #42

Merged
merged 44 commits into from
Aug 15, 2022
Merged

Feature/podaac 4658 #42

merged 44 commits into from
Aug 15, 2022

Conversation

Phoeneix
Copy link
Contributor

Description

Update automatic testing for concise so it outputs reporting, including send a slack message. Similar to l2ss-py automatic testing.

Overview of work done

Summarize the work you did

Overview of verification done

https://github.com/podaac/concise/actions/runs/2836738192

Overview of integration done

Explain how this change was integration tested. Provide screenshots or logs if appropriate. An example of this would be a local Harmony deployment.

PR checklist:

  • Linted
  • Updated unit tests
  • Updated changelog
  • Integration testing

See Pull Request Review Checklist for pointers on reviewing this pull request

@Phoeneix Phoeneix requested a review from jamesfwood August 11, 2022 01:15
@@ -0,0 +1,92 @@
import argparse
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file doesn't belong in concise. Can we move it to umm-updater maybe?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is for calling the cmr updater. It imports the necessary methods from it to remove association.
The code for removing the association is in the cmr-updater repo and we are importing it from there.
The l2ss-py has a similar file for calling the cmr-updater.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Phoeneix Phoeneix merged commit b073214 into develop Aug 15, 2022
@Phoeneix Phoeneix deleted the feature/podaac-4658 branch August 15, 2022 20:04
@Phoeneix Phoeneix restored the feature/podaac-4658 branch August 15, 2022 20:58
@Phoeneix Phoeneix deleted the feature/podaac-4658 branch August 15, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants