Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update concise json history to have granule url in derived from #88

Merged
merged 1 commit into from
Oct 25, 2023
Merged

update concise json history to have granule url in derived from #88

merged 1 commit into from
Oct 25, 2023

Conversation

sliu008
Copy link
Contributor

@sliu008 sliu008 commented Oct 25, 2023

Description

  • Update history json to have urls of granules used

Overview of work done

  • Added granule_urls as function parameters and used in in history json derived from

Overview of verification done

  • Tested in local harmony to make sure urls are in history json

Overview of integration done

Explain how this change was integration tested. Provide screenshots or logs if appropriate. An example of this would be a local Harmony deployment.

PR checklist:

  • Linted
  • Updated unit tests
  • Updated changelog
  • Integration testing

See Pull Request Review Checklist for pointers on reviewing this pull request

@sliu008 sliu008 requested a review from jamesfwood October 25, 2023 16:58
@sliu008 sliu008 merged commit c65a556 into develop Oct 25, 2023
2 of 3 checks passed
@sliu008 sliu008 deleted the feature/update_history_json branch October 25, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesfwood jamesfwood jamesfwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sliu008 @jamesfwood