Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created onboarding taskList #14

Merged
merged 3 commits into from
May 17, 2023
Merged

Created onboarding taskList #14

merged 3 commits into from
May 17, 2023

Conversation

vitorschelb
Copy link
Contributor

@vitorschelb vitorschelb commented May 15, 2023 •
edited
Loading

Description

This PR [Created accordion component for checklist user onboarding experience]

  • created component
  • added ts types

Next Steps

  • check if it needs refactoring
  • create separated files with checklist data
  • create checkbox on labels
  • add persistence
  • console keeps showing "true, false". Solve this

@vercel
Copy link

vercel bot commented May 15, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2023 5:44pm

@vitorschelb vitorschelb self-assigned this May 15, 2023
vitorschelb
vitorschelb commented May 15, 2023
View reviewed changes
Copy link
Contributor Author

@vitorschelb vitorschelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for the replies. Thank you for your time guys!

marco-souza
marco-souza reviewed May 16, 2023
View reviewed changes
Copy link
Contributor

@marco-souza marco-souza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 🥳

Friendly reminder to update the PR title for some text more Human-readable

Another suggestion is to open the PR as a draft when you are submitting it for review before the feature is finished!

src/app/app/dashboard/page.tsx Outdated Show resolved Hide resolved
src/app/app/dashboard/page.tsx Outdated Show resolved Hide resolved
src/components/Accordion.tsx Outdated Show resolved Hide resolved
src/components/Accordion.tsx Outdated Show resolved Hide resolved
src/components/Accordion.tsx Outdated Show resolved Hide resolved
nicolasbrandao
nicolasbrandao approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@nicolasbrandao nicolasbrandao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice job! 🚀

@vitorschelb vitorschelb changed the title Vitorschelb/onboarding Vitorschelb/onboarding -> Created onboarding TaskList May 17, 2023
@vitorschelb vitorschelb changed the title Vitorschelb/onboarding -> Created onboarding TaskList Created onboarding taskList May 17, 2023
@vitorschelb vitorschelb merged commit 6d2921a into main May 17, 2023
@vitorschelb vitorschelb deleted the vitorschelb/onboarding branch May 17, 2023 17:51
nicolasbrandao
nicolasbrandao reviewed May 19, 2023
View reviewed changes
Copy link
Contributor

@nicolasbrandao nicolasbrandao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I'm late for this one haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasbrandao nicolasbrandao nicolasbrandao approved these changes

@marco-souza marco-souza marco-souza approved these changes

Assignees

@vitorschelb vitorschelb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vitorschelb @marco-souza @nicolasbrandao