Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance login UI form #15

Merged
merged 7 commits into from
May 17, 2023
Merged

Enhance login UI form #15

merged 7 commits into from
May 17, 2023

Conversation

nicolasbrandao
Copy link
Contributor

@nicolasbrandao nicolasbrandao commented May 16, 2023 •
edited
Loading

Description

This PR improves login UI form according to @marco-souza comments on #13

  • Remove sign in form inputs that are not necessary on the MVP
  • Remove unused import
  • Remove use of callbackUrl from the sign in button
  • Create login providers type

Next Steps

  • Implement Google Auth Provider

@vercel
Copy link

vercel bot commented May 16, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2023 1:30pm

vitorschelb
vitorschelb approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@vitorschelb vitorschelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Nice changes, good work!

marco-souza
marco-souza reviewed May 16, 2023
View reviewed changes
Copy link
Contributor

@marco-souza marco-souza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for those changes!

Left a couple of minor adjustment, but it's mostly looking good 👍🏼

src/components/SignInButton.tsx Outdated Show resolved Hide resolved
src/components/SignInForm.tsx Outdated Show resolved Hide resolved
vitorschelb
vitorschelb approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@vitorschelb vitorschelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner! Nice job!

marco-souza
marco-souza approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@marco-souza marco-souza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢

@nicolasbrandao nicolasbrandao merged commit 5a3bced into main May 17, 2023
@nicolasbrandao nicolasbrandao deleted the nicolasbrandao/login-ui branch May 17, 2023 18:16
@nicolasbrandao nicolasbrandao self-assigned this May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitorschelb vitorschelb vitorschelb approved these changes

@marco-souza marco-souza marco-souza approved these changes

@guilherme-bbsa guilherme-bbsa Awaiting requested review from guilherme-bbsa

@Raysson-ornelas Raysson-ornelas Awaiting requested review from Raysson-ornelas

Assignees

@nicolasbrandao nicolasbrandao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolasbrandao @marco-souza @vitorschelb