Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create form route and mockup #22

Merged
merged 4 commits into from
May 25, 2023
Merged

Create form route and mockup #22

merged 4 commits into from
May 25, 2023

Conversation

vitorschelb
Copy link
Contributor

@vitorschelb vitorschelb commented May 19, 2023 •
edited
Loading

Description

This PR Create form route and mockup form

  • Create appDir route /app/form
  • Create Form mockup
  • Create form questions
  • Create form TW classes
  • Create onboardingUtils

Next Steps

  • Create generic button for form submits
  • Add logic

@vitorschelb vitorschelb self-assigned this May 19, 2023
@vercel
Copy link

vercel bot commented May 19, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2023 1:38pm

@vitorschelb vitorschelb changed the title Create form route Create form route and mockup May 19, 2023
@vitorschelb vitorschelb marked this pull request as draft May 19, 2023 21:35
vitorschelb
vitorschelb commented May 19, 2023
View reviewed changes
Copy link
Contributor Author

@vitorschelb vitorschelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporary mockup for Forms created.
Waiting for reviews to complete next steps!

marco-souza
marco-souza reviewed May 20, 2023
View reviewed changes
src/app/app/form/layout.tsx Outdated Show resolved Hide resolved
src/app/app/form/page.tsx Outdated Show resolved Hide resolved
src/components/OnboardingForm.tsx Show resolved Hide resolved
src/components/OnboardingForm.tsx Outdated Show resolved Hide resolved
vitorschelb
vitorschelb commented May 23, 2023
View reviewed changes
Copy link
Contributor Author

@vitorschelb vitorschelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Deleted layout.
  • Renamed Route

marco-souza
marco-souza approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@marco-souza marco-souza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 🚢

vitorschelb
vitorschelb commented May 24, 2023
View reviewed changes
src/app/globals.css Outdated Show resolved Hide resolved
src/components/OnboardingForm.tsx Outdated Show resolved Hide resolved
tailwind.config.js Outdated Show resolved Hide resolved
marco-souza
marco-souza reviewed May 24, 2023
View reviewed changes
Copy link
Contributor

@marco-souza marco-souza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think we merge it as it was previously? This PR it's already 9 commits long, it's not a good place to be.

We can continue the other tasks into other PRs, no need to conitnue working on this one

src/app/globals.css Outdated Show resolved Hide resolved
@vitorschelb vitorschelb marked this pull request as ready for review May 25, 2023 18:52
@vitorschelb vitorschelb merged commit dbf83eb into main May 25, 2023
@vitorschelb vitorschelb deleted the vitorschelb/form branch May 25, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-souza marco-souza marco-souza approved these changes

@nicolasbrandao nicolasbrandao Awaiting requested review from nicolasbrandao

Assignees

@nicolasbrandao nicolasbrandao

@vitorschelb vitorschelb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vitorschelb @marco-souza @nicolasbrandao