Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create user profile route #23

Merged
merged 1 commit into from
May 24, 2023
Merged

Create user profile route #23

merged 1 commit into from
May 24, 2023

Conversation

nicolasbrandao
Copy link
Contributor

@nicolasbrandao nicolasbrandao commented May 22, 2023 •
edited
Loading

Description

This PR creates a dynamic route for profile pages

  • Create the /[username] folder in /app with its corresponding page.tsx file

Note: For the moment, I implemented simple redirect logic based on the session email as mock up username - user won't be able to acess a profile route unless he's the one logged in (assuming no users will have the first half of their emails be the same). This should be changed soon as we link the app to a DB.

Next Steps

  • Actually link this to a DB and use proper validation and access rules
  • Implement actual access rules to the profile pages
  • Create profile page UI

@vercel
Copy link

vercel bot commented May 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
app ✅ Ready (Inspect) Visit Preview May 22, 2023 10:53pm

@nicolasbrandao nicolasbrandao self-assigned this May 23, 2023
vitorschelb
vitorschelb approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@vitorschelb vitorschelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nicolasbrandao nicolasbrandao marked this pull request as ready for review May 24, 2023 21:56
@nicolasbrandao nicolasbrandao merged commit 1c047c1 into main May 24, 2023
@nicolasbrandao nicolasbrandao deleted the nicolasbrandao/profile-route branch May 24, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitorschelb vitorschelb vitorschelb approved these changes

@marco-souza marco-souza marco-souza approved these changes

@Raysson-ornelas Raysson-ornelas Awaiting requested review from Raysson-ornelas

@guilherme-bbsa guilherme-bbsa Awaiting requested review from guilherme-bbsa

Assignees

@nicolasbrandao nicolasbrandao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolasbrandao @marco-souza @vitorschelb