Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve profile page UI #24

Merged
merged 5 commits into from
May 31, 2023
Merged

Conversation

nicolasbrandao
Copy link
Contributor

@nicolasbrandao nicolasbrandao commented May 25, 2023

Description

This PR improves the profile page UI

  • Improve UI for desktop and mobile
    image
    image

One of the commits creates tailwind color variables with the Figma PodCodar colors. This was commited by @vitorschelb on his previou PR, not really sure on how this is gonna roll out, but I expect no conflicts as the code is exactly the same.

Next Steps

  • Use data from DB instead of mockup data

@vercel
Copy link

vercel bot commented May 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2023 8:19pm

src/app/app/[username]/page.tsx Outdated Show resolved Hide resolved
src/app/globals.css Outdated Show resolved Hide resolved
src/components/Profile.tsx Outdated Show resolved Hide resolved
src/components/Profile.tsx Outdated Show resolved Hide resolved
src/components/Profile.tsx Outdated Show resolved Hide resolved
src/components/Profile.tsx Outdated Show resolved Hide resolved
src/components/Profile.tsx Outdated Show resolved Hide resolved
tailwind.config.js Outdated Show resolved Hide resolved
src/components/Profile.tsx Outdated Show resolved Hide resolved
src/components/Profile.tsx Outdated Show resolved Hide resolved
src/shared/makeImageSizes.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@vitorschelb vitorschelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Copy link
Contributor

@marco-souza marco-souza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crème de la crème ⭐️

@nicolasbrandao nicolasbrandao merged commit 56c4afe into main May 31, 2023
@nicolasbrandao nicolasbrandao deleted the nicolasbrandao/profile-page-ui branch May 31, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants