Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaks OnboardingForm into MultistepForm #32

Merged
merged 7 commits into from
Jun 20, 2023
Merged

Breaks OnboardingForm into MultistepForm #32

merged 7 commits into from
Jun 20, 2023

Conversation

vitorschelb
Copy link
Contributor

This PR breaks OnboardingForm into a MultiStepForm using a hook to manage the steps state

This PR [short description here]

  • Create hook
  • Create multistep page
  • Create progress dots
  • Breaks the form
  • Install TS Eslint Plugin

Next Steps

  • Next PRs will be handling the TODO list in multistep page

@vitorschelb vitorschelb self-assigned this Jun 8, 2023
@vercel
Copy link

vercel bot commented Jun 8, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2023 1:24pm

vitorschelb
vitorschelb commented Jun 8, 2023
View reviewed changes
Copy link
Contributor Author

@vitorschelb vitorschelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the first PR for the Multistep form, and the next PRs are described on the Multistep page.

src/components/Navbar.tsx Outdated Show resolved Hide resolved
.eslintrc.json Outdated Show resolved Hide resolved
marco-souza
marco-souza reviewed Jun 10, 2023
View reviewed changes
Copy link
Contributor

@marco-souza marco-souza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O nome ta errado. nao deveria se /app/onboarding? o Multistep era somente para exemplificar

marco-souza
marco-souza reviewed Jun 10, 2023
View reviewed changes
src/components/Navbar.tsx Outdated Show resolved Hide resolved
.eslintrc.json Outdated Show resolved Hide resolved
src/components/forms/OnboardingRegistrationForm.tsx Outdated Show resolved Hide resolved
src/components/forms/OnboardingProfessionalForm.tsx Outdated Show resolved Hide resolved
marco-souza
marco-souza reviewed Jun 10, 2023
View reviewed changes
.eslintrc.json Outdated Show resolved Hide resolved
src/components/forms/OnboardingProfessionalForm.tsx Outdated Show resolved Hide resolved
src/components/forms/OnboardingProfessionalForm.tsx Outdated Show resolved Hide resolved
src/components/forms/OnboardingRegistrationForm.tsx Outdated Show resolved Hide resolved
marco-souza
marco-souza reviewed Jun 13, 2023
View reviewed changes
src/app/app/multistep/page.tsx Outdated Show resolved Hide resolved
src/app/app/multistep/page.tsx Outdated Show resolved Hide resolved
vitorschelb
vitorschelb commented Jun 20, 2023
View reviewed changes
Copy link
Contributor Author

@vitorschelb vitorschelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR suggestions applied.

marco-souza
marco-souza approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@marco-souza marco-souza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@vitorschelb vitorschelb merged commit f074d6f into main Jun 20, 2023
@vitorschelb vitorschelb deleted the vitorschelb/multistep-form branch June 20, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasbrandao nicolasbrandao nicolasbrandao left review comments

@vzsoares vzsoares vzsoares left review comments

@marco-souza marco-souza marco-souza approved these changes

Assignees

@vitorschelb vitorschelb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vitorschelb @marco-souza @vzsoares @nicolasbrandao