Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List no-dependenciy tasks and assign to user #59

Merged
merged 7 commits into from
Aug 30, 2023
Merged

List no-dependenciy tasks and assign to user #59

merged 7 commits into from
Aug 30, 2023

Conversation

vitorschelb
Copy link
Contributor

@vitorschelb vitorschelb commented Aug 28, 2023 •
edited
Loading

#50

This PR creates a list no-dependenciy tasks and assign to user

  • Ref dependency tasks on seed
  • Create class TasksDAO on tasks.dao.ts with method to look for all tasks that don't depend on other tasks.
  • Creates method on DB to assing these tasks to the user (UserTasks table)
  • Assign the no-dependency tasks to the user on the pos onboarding route flow

@vitorschelb vitorschelb self-assigned this Aug 28, 2023
@vitorschelb vitorschelb linked an issue Aug 28, 2023 that may be closed by this pull request
Implement pos-onboarding flow #50
Closed
2 tasks
@vercel
Copy link

vercel bot commented Aug 28, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 6:00pm

marco-souza
marco-souza approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@marco-souza marco-souza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

I left some minor style comments, but LGTM!

src/app/api/onboarding/route.ts Outdated Show resolved Hide resolved
src/shared/db.ts Outdated Show resolved Hide resolved
@marco-souza
Copy link
Contributor

we still need to resolve the integration test before merging it

@marco-souza
Copy link
Contributor

Also, friendly reminder to update the PR title, to something more readable

@vitorschelb vitorschelb changed the title Vitorschelb/50 implement pos onboarding flow List no-dependenciy tasks and assign to user Aug 29, 2023
marco-souza
marco-souza requested changes Aug 30, 2023
View reviewed changes
src/tests/db.test.ts Outdated Show resolved Hide resolved
marco-souza
marco-souza approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@marco-souza marco-souza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Way

@vitorschelb vitorschelb merged commit 772ad2c into main Aug 30, 2023
@vitorschelb vitorschelb deleted the vitorschelb/50-implement-pos-onboarding-flow branch August 30, 2023 18:45
@marco-souza marco-souza mentioned this pull request Oct 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-souza marco-souza marco-souza approved these changes

@Raysson-ornelas Raysson-ornelas Awaiting requested review from Raysson-ornelas

@vzsoares vzsoares Awaiting requested review from vzsoares

@nicolasbrandao nicolasbrandao Awaiting requested review from nicolasbrandao

Assignees

@vitorschelb vitorschelb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement pos-onboarding flow
2 participants
@vitorschelb @marco-souza