Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User tasks on the dashboard is now integrated with the DB #65

Merged
merged 8 commits into from
Sep 1, 2023
Merged

User tasks on the dashboard is now integrated with the DB #65

merged 8 commits into from
Sep 1, 2023

Conversation

nicolasbrandao
Copy link
Contributor

@nicolasbrandao nicolasbrandao commented Sep 1, 2023 •
edited
Loading

Description

This PR now gets and sets tasks on the DB instead of local storage. This PR closes issue #58

  • Remove old local storage logic
  • Create TaskDAO method for checking tasks
  • Create Next API route for checking tasks
  • Add logic for getting data from the DB through NextAPI on the front-end

@nicolasbrandao nicolasbrandao self-assigned this Sep 1, 2023
@vercel
Copy link

vercel bot commented Sep 1, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 1, 2023 6:32pm

marco-souza
marco-souza approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@marco-souza marco-souza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the way

src/components/TaskList.tsx Outdated Show resolved Hide resolved
@marco-souza
Copy link
Contributor

@nicolasbrandao Friendly reminder to add the task id on the PR description using # so the issue is closed automagically 🪄

@nicolasbrandao
Copy link
Contributor Author

@nicolasbrandao Friendly reminder to add the task id on the PR description using # so the issue is closed automagically 🪄

You're right. I'll do it now. Thanks for the reminder!

@nicolasbrandao nicolasbrandao merged commit a122993 into main Sep 1, 2023
@nicolasbrandao nicolasbrandao deleted the nicolasbrandao/58-list-tasks-from-db branch September 1, 2023 18:42
@marco-souza marco-souza linked an issue Sep 18, 2023 that may be closed by this pull request
List tasks on the UI #58
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-souza marco-souza marco-souza approved these changes

@vitorschelb vitorschelb Awaiting requested review from vitorschelb

Assignees

@nicolasbrandao nicolasbrandao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

List tasks on the UI
2 participants
@nicolasbrandao @marco-souza