Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Next Auth and Bundle Analyzer to app #7

Merged
merged 10 commits into from
May 10, 2023
Merged

Implement Next Auth and Bundle Analyzer to app #7

merged 10 commits into from
May 10, 2023

Conversation

nicolasbrandao
Copy link
Contributor

@nicolasbrandao nicolasbrandao commented May 10, 2023 •
edited
Loading

Description

  • Install Next Auth
  • Add auth app route
  • Add login private route
  • Add pathname origin middleware
  • Add bundle analyzer

Next steps

@nicolasbrandao nicolasbrandao self-assigned this May 10, 2023
@vercel
Copy link

vercel bot commented May 10, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2023 11:22pm

marco-souza
marco-souza approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@marco-souza marco-souza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢

src/app/admin/layout.tsx Show resolved Hide resolved
src/app/api/auth/[...nextauth]/route.ts Show resolved Hide resolved
@nicolasbrandao nicolasbrandao merged commit aca5dae into main May 10, 2023
@nicolasbrandao nicolasbrandao deleted the nextauth branch May 10, 2023 23:29
vitorschelb
vitorschelb reviewed May 11, 2023
View reviewed changes
Copy link
Contributor

@vitorschelb vitorschelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Amazing.

package.json
@@ -7,17 +7,20 @@
"build": "next build",
"start": "next start",
"fmt": "next lint --fix",
"lint": "next lint"
"lint": "next lint",
"analyze": "ANALYZE=true yarn build"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should change this to use PNPM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitorschelb vitorschelb vitorschelb left review comments

@marco-souza marco-souza marco-souza approved these changes

@guilherme-bbsa guilherme-bbsa Awaiting requested review from guilherme-bbsa

Assignees

@nicolasbrandao nicolasbrandao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolasbrandao @marco-souza @vitorschelb