Skip to content

Conversation

daniel-sc
Copy link
Member

This closes #113 and closes #111

This as well resolves PR #121

@daniel-sc daniel-sc force-pushed the separating-classes-to-files branch from aa31588 to 798da48 Compare October 14, 2019 06:50
@daniel-sc daniel-sc force-pushed the separating-classes-to-files branch from 798da48 to 81e6584 Compare October 14, 2019 07:05
@daniel-sc
Copy link
Member Author

Ok - now I won't change this PR any more ;)
Review @carlfredrikhero @rafaelmb @bajarang-agarwal @timosillander @dylannadon ?

Copy link
Member

@rafaelmb rafaelmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job Daniel!

@daniel-sc
Copy link
Member Author

Hi @carlfredrikhero @bajarang-agarwal @timosillander @dylannadon,

no feedback == this PR has problems? Critical feedback as well highly appreciated!

@daniel-sc daniel-sc merged commit d50bfc8 into master Nov 3, 2019
@daniel-sc daniel-sc deleted the separating-classes-to-files branch November 3, 2019 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fatal error on using composer with PodioItemField Autoloader not working with composer with PodioItemField
2 participants