Skip to content

Conversation

trygve-lie
Copy link
Contributor

HttpIncoming lives in hot path of every request. This PR doubles the creation performance of HttpIncoming.

From:

new HttpIncoming() - No params x 91,806 ops/sec ±2.48% (85 runs sampled)
new HttpIncoming() - With params x 92,816 ops/sec ±2.34% (85 runs sampled)

to:

new HttpIncoming() - No params x 186,691 ops/sec ±1.04% (90 runs sampled)
new HttpIncoming() - With params x 186,027 ops/sec ±1.54% (92 runs sampled)

There is probably more performance to press out of this but that involves taking a stab on the original-url module.

@trygve-lie trygve-lie requested a review from digitalsadhu March 15, 2019 18:33
@trygve-lie trygve-lie merged commit e8b379b into master Mar 21, 2019
@trygve-lie trygve-lie deleted the http-incoming-bench branch March 21, 2019 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant