Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Livestream pager links to empty section #1226

Open
Marzal opened this issue Dec 8, 2023 · 2 comments
Open

Livestream pager links to empty section #1226

Marzal opened this issue Dec 8, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@Marzal
Copy link
Contributor

Marzal commented Dec 8, 2023

Describe the bug
The logic behind the calculation of livestreams seems off

To Reproduce
Clink on page number 4

Screenshots
https://github.com/podverse/podverse-web/assets/2069735/24c5c9d1-94fc-46eb-8c96-45603ff1e113

@Marzal Marzal added the bug Something isn't working label Dec 8, 2023
@mitchdowney mitchdowney self-assigned this Dec 13, 2023
@mitchdowney
Copy link
Member

This issue happens because I am not actually querying for the page count before rendering the pagination button, so the UI is just guessing / loading by default as if there are 5+ pages. It's an ugly bug when you run into it...but I don't know how to query for a count of ALL the livestreams efficiently on each page load. I'd like to fix this, but it's also not one of the highest priorities right at the moment, so I'm going to unassign it from me for now.

@mitchdowney mitchdowney removed their assignment Apr 30, 2024
@Marzal
Copy link
Contributor Author

Marzal commented Apr 30, 2024

It a very low priority bug, no problem. In fact when you encounter it the workaround is obvious.

I reported it so it's documented, just that. Keep up the good work when is more important 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants