Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the DeleteAccountModal use a different confirmation text depending on i18n translations #1234

Open
mitchdowney opened this issue Dec 29, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@mitchdowney
Copy link
Member

Currently the confirm prompt is hardcoded to look for the string "delete", but that is confusing for non-English speakers. I think we should change that to be dynamic based on the i18n translation, and if a translation isn't available, fallback to "delete".

https://github.com/podverse/podverse-web/blob/develop/src/components/Modals/Auth/ConfirmDeleteAccountModal.tsx#L23

@mitchdowney mitchdowney added the enhancement New feature or request label Dec 29, 2023
@Marzal
Copy link
Contributor

Marzal commented Dec 31, 2023

I think is not a big problem for the Spanish community, if the sentence says write "whatever" no one should have any problem in replicate that word.

If changing the logic may complicate things I would leave it hardcoded, because make it depend in the translation, open a fail point in case the translator that you would need to check.

My question, was just to be sure, what word to put in the translation string, in case that multilingual was already implemented. I would leave "delete" for the moment, and keep and eye in this issue.

Happy new year!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants