You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the confirm prompt is hardcoded to look for the string "delete", but that is confusing for non-English speakers. I think we should change that to be dynamic based on the i18n translation, and if a translation isn't available, fallback to "delete".
I think is not a big problem for the Spanish community, if the sentence says write "whatever" no one should have any problem in replicate that word.
If changing the logic may complicate things I would leave it hardcoded, because make it depend in the translation, open a fail point in case the translator that you would need to check.
My question, was just to be sure, what word to put in the translation string, in case that multilingual was already implemented. I would leave "delete" for the moment, and keep and eye in this issue.
Currently the confirm prompt is hardcoded to look for the string
"delete"
, but that is confusing for non-English speakers. I think we should change that to be dynamic based on the i18n translation, and if a translation isn't available, fallback to"delete"
.https://github.com/podverse/podverse-web/blob/develop/src/components/Modals/Auth/ConfirmDeleteAccountModal.tsx#L23
The text was updated successfully, but these errors were encountered: