Support enums with cases wrapped in #if #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewVebster
commented
Dec 5, 2023
Comment on lines
+111
to
+120
| if let ifConfigDecl = $0.decl.as(IfConfigDeclSyntax.self) { | ||
| let ifClauses = ifConfigDecl.clauses.flatMap { decl -> [DeclSyntax] in | ||
| guard let elements = decl.elements?.as(MemberBlockItemListSyntax.self) else { | ||
| return [] | ||
| } | ||
| let title = "\(decl.poundKeyword.text) \(decl.condition?.description ?? "")" | ||
| return ["\(raw: title)"] + generateDeclSyntax(from: elements, with: access, enumName: enumName) | ||
| } | ||
| return ifClauses + ["#endif"] | ||
| } |
There was a problem hiding this comment.
Essentially, only this part is new. Here we parse the condition and then recursively look for EnumCaseDeclSyntax which are part of this IfConfigDeclSyntax as elements property.
For example, this code 👇
#if os(macOS)
case macCase
Would be represented by this IfConfigDeclSyntax type 👇
IfConfigDeclSyntax
├─clauses: IfConfigClauseListSyntax
│ ├─[0]: IfConfigClauseSyntax
│ │ ├─poundKeyword: poundIf
│ │ ├─condition: FunctionCallExprSyntax
│ │ │ ├─calledExpression: DeclReferenceExprSyntax
│ │ │ │ ╰─baseName: identifier("os")
│ │ │ ├─leftParen: leftParen
│ │ │ ├─arguments: LabeledExprListSyntax
│ │ │ │ ╰─[0]: LabeledExprSyntax
│ │ │ │ ╰─expression: DeclReferenceExprSyntax
│ │ │ │ ╰─baseName: identifier("macOS")
│ │ │ ├─rightParen: rightParen
│ │ │ ╰─additionalTrailingClosures: MultipleTrailingClosureElementListSyntax
│ │ ╰─elements: MemberBlockItemListSyntax
│ │ ├─[0]: MemberBlockItemSyntax
│ │ │ ╰─decl: EnumCaseDeclSyntax
│ │ │ ├─attributes: AttributeListSyntax
│ │ │ ├─modifiers: DeclModifierListSyntax
│ │ │ ├─caseKeyword: keyword(SwiftSyntax.Keyword.case)
│ │ │ ╰─elements: EnumCaseElementListSyntax
│ │ │ ╰─[0]: EnumCaseElementSyntax
│ │ │ ╰─name: identifier("macCase")
stephencelis
approved these changes
Dec 5, 2023
|
Happy to contribute 😉 🙌 |
johankool
pushed a commit
to johankool/swift-case-paths
that referenced
this pull request
Nov 2, 2024
…upport, Xcode 16 (pointfreeco#133) * Address build issues in Library Evolution mode Address build issues seen building for library evolution mode, Xcode 16 - i.e. `make build-for-library-evolution`. * Update ci.yml --------- Co-authored-by: Stephen Celis <stephen.celis@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the macro code to allow it to generate case paths for cases which are conditionally compiled. For example:
Currently released implementation would generate the case path only for
bar.Why
I'm working on a project where we use TCA. Because we share the code between iOS and macOS we have a few places where one platform has some additional actions (features) and they are wrapped with
#if os.What do you think? Would it be useful? Appreciate any feedback 🙂