Skip to content

Re-adds Reducer.forEach method removed in 1.4 #2570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 15, 2023
Merged

Re-adds Reducer.forEach method removed in 1.4 #2570

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a885ed1
Re-adds an initialiser that was removed in 1.4
rhysm94 Nov 15, 2023
53dd953
Update ForEachReducer.swift
stephencelis Nov 15, 2023
58c4d0a
Merge branch 'main' into restore-broken-foreach-initialiser
stephencelis Nov 15, 2023
a1ac977
Update ForEachReducer.swift
stephencelis Nov 15, 2023
a0cb456
Merge branch 'main' into restore-broken-foreach-initialiser
stephencelis Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 9 additions & 50 deletions Sources/ComposableArchitecture/Reducer/Reducers/ForEachReducer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,31 +122,31 @@ extension Reducer {
iOS,
deprecated: 9999,
message:
"Use an 'IdentifiedAction', instead. See the following migration guide for more information:\n\nhttps://pointfreeco.github.io/swift-composable-architecture/main/documentation/composablearchitecture/Migratingto14#Identified-actions"
"Use a case key path to an 'IdentifiedAction', instead. See the following migration guide for more information:\n\nhttps://pointfreeco.github.io/swift-composable-architecture/main/documentation/composablearchitecture/migratingto1.4"
)
@available(
macOS,
deprecated: 9999,
message:
"Use an 'IdentifiedAction', instead. See the following migration guide for more information:\n\nhttps://pointfreeco.github.io/swift-composable-architecture/main/documentation/composablearchitecture/Migratingto14#Identified-actions"
"Use a case key path to an 'IdentifiedAction', instead. See the following migration guide for more information:\n\nhttps://pointfreeco.github.io/swift-composable-architecture/main/documentation/composablearchitecture/migratingto1.4"
)
@available(
tvOS,
deprecated: 9999,
message:
"Use an 'IdentifiedAction', instead. See the following migration guide for more information:\n\nhttps://pointfreeco.github.io/swift-composable-architecture/main/documentation/composablearchitecture/Migratingto14#Identified-actions"
"Use a case key path to an 'IdentifiedAction', instead. See the following migration guide for more information:\n\nhttps://pointfreeco.github.io/swift-composable-architecture/main/documentation/composablearchitecture/migratingto1.4"
)
@available(
watchOS,
deprecated: 9999,
message:
"Use an 'IdentifiedAction', instead. See the following migration guide for more information:\n\nhttps://pointfreeco.github.io/swift-composable-architecture/main/documentation/composablearchitecture/Migratingto14#Identified-actions"
"Use a case key path to an 'IdentifiedAction', instead. See the following migration guide for more information:\n\nhttps://pointfreeco.github.io/swift-composable-architecture/main/documentation/composablearchitecture/migratingto1.4"
)
@inlinable
@warn_unqualified_access
public func forEach<ElementState, ElementAction, ID: Hashable, Element: Reducer>(
_ toElementsState: WritableKeyPath<State, IdentifiedArray<ID, ElementState>>,
action toElementAction: CaseKeyPath<Action, (id: ID, action: ElementAction)>,
action toElementAction: AnyCasePath<Action, (ID, ElementAction)>,
@ReducerBuilder<ElementState, ElementAction> element: () -> Element,
fileID: StaticString = #fileID,
line: UInt = #line
Expand All @@ -155,51 +155,10 @@ extension Reducer {
_ForEachReducer(
parent: self,
toElementsState: toElementsState,
toElementAction: AnyCasePath(toElementAction),
element: element(),
fileID: fileID,
line: line
)
}

@available(
iOS,
deprecated: 9999,
message:
"Use an 'IdentifiedAction', instead. See the following migration guide for more information:\n\nhttps://pointfreeco.github.io/swift-composable-architecture/main/documentation/composablearchitecture/Migratingto14#Identified-actions"
)
@available(
macOS,
deprecated: 9999,
message:
"Use an 'IdentifiedAction', instead. See the following migration guide for more information:\n\nhttps://pointfreeco.github.io/swift-composable-architecture/main/documentation/composablearchitecture/Migratingto14#Identified-actions"
)
@available(
tvOS,
deprecated: 9999,
message:
"Use an 'IdentifiedAction', instead. See the following migration guide for more information:\n\nhttps://pointfreeco.github.io/swift-composable-architecture/main/documentation/composablearchitecture/Migratingto14#Identified-actions"
)
@available(
watchOS,
deprecated: 9999,
message:
"Use an 'IdentifiedAction', instead. See the following migration guide for more information:\n\nhttps://pointfreeco.github.io/swift-composable-architecture/main/documentation/composablearchitecture/Migratingto14#Identified-actions"
)
@inlinable
@warn_unqualified_access
public func forEach<ElementState, ElementAction, ID: Hashable, Element: Reducer>(
_ toElementsState: WritableKeyPath<State, IdentifiedArray<ID, ElementState>>,
action toElementAction: AnyCasePath<Action, (id: ID, action: ElementAction)>,
@ReducerBuilder<ElementState, ElementAction> element: () -> Element,
fileID: StaticString = #fileID,
line: UInt = #line
) -> _ForEachReducer<Self, ID, Element>
where ElementState == Element.State, ElementAction == Element.Action {
_ForEachReducer(
parent: self,
toElementsState: toElementsState,
toElementAction: toElementAction,
toElementAction: .init(
embed: toElementAction.embed,
extract: toElementAction.extract
),
element: element(),
fileID: fileID,
line: line
Expand Down