Add file:line: to unimplemented
#36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephencelis
commented
Nov 14, 2022
stephencelis
commented
Nov 14, 2022
| as Any as? NSObjectProtocol, | ||
| String(describing: XCTestObservationCenter) != "<null>", | ||
| let XCTestObservationCenter = NSClassFromString("XCTestObservationCenter"), | ||
| let XCTestObservationCenter = XCTestObservationCenter as Any as? NSObjectProtocol, |
There was a problem hiding this comment.
This is a fix for #34.
stephencelis
commented
Nov 14, 2022
| Defined at: | ||
| \(fileID):\(line) |
There was a problem hiding this comment.
This will technically point to unimplemented's position when using XCTUnimplemented...but I figure that's deprecated and the churn of updating all the docs didn't feel worth it...
mbrandonw
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.