Skip to content

FIX: NavigationStackController subclass delegate methods are not called #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 23, 2025
Merged

FIX: NavigationStackController subclass delegate methods are not called #307

merged 3 commits into from
Sep 23, 2025
+147 −1

Conversation

acosmicflamingo
Copy link
Contributor

@acosmicflamingo acosmicflamingo commented Sep 23, 2025 •
edited
Loading

Taking a crack at trying to write tests for this PR that catch NavigationStackController's currently failing interactive pop gestures. Once I get the failures, I'll cherry-pick @takehilo's commit e82d112 that fixes it to confirm the problem does indeed go away.

@acosmicflamingo acosmicflamingo changed the title Fix delegates methods are not called FIX: NavigationStackController subclass delegate methods are not called Sep 23, 2025
@acosmicflamingo
Copy link
Contributor Author

Whoops; I was working off of an old main branch...

@acosmicflamingo acosmicflamingo force-pushed the fix-delegates-methods-are-not-called branch from d6a4e9b to ae2728c Compare September 23, 2025 02:39
@acosmicflamingo
Copy link
Contributor Author

Great, I see the failure here:

Test Case '-[CaseStudiesTests.NavigationStackTests testInteractivePopViaGestureAction]' started.
2025-09-23 02:49:28.015344+0000 CaseStudies[14425:59179] Unbalanced calls to begin/end appearance transitions for <UIViewController: 0x103f77770>.
/Users/runner/work/swift-navigation/swift-navigation/Examples/CaseStudiesTests/NavigationStackTests.swift:371: error: -[CaseStudiesTests.NavigationStackTests testInteractivePopViaGestureAction] : Asynchronous wait failed: Exceeded timeout of 1 seconds, with unfulfilled expectations: "navigationController(_:interactionControllerFor:) called".
/Users/runner/work/swift-navigation/swift-navigation/Examples/CaseStudiesTests/NavigationStackTests.swift:373: error: -[CaseStudiesTests.NavigationStackTests testInteractivePopViaGestureAction] : XCTAssertTrue failed
Test Case '-[CaseStudiesTests.NavigationStackTests testInteractivePopViaGestureAction]' failed (3.263 seconds).

Now to cherry-pick the changes and apply them here.

@acosmicflamingo acosmicflamingo mentioned this pull request Sep 23, 2025
Closed
stephencelis
stephencelis approved these changes Sep 23, 2025
View reviewed changes
Copy link
Member

@stephencelis stephencelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@stephencelis stephencelis merged commit cc167df into pointfreeco:main Sep 23, 2025
5 checks passed
@acosmicflamingo acosmicflamingo deleted the fix-delegates-methods-are-not-called branch September 23, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephencelis stephencelis stephencelis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acosmicflamingo @stephencelis @takehilo