Fix uinavigationcontrollerdelegate forwarding for real #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acosmicflamingo
force-pushed
the
fix-uinavigationcontrollerdelegate-forwarding-for-real
branch
2 times, most recently
from
68b8583 to
da98da1
Compare
|
Looks like that failure in da98da1 was a false positive. This PR is good for merging then. Edit: pushed final change to remove random .orig file that appeared. |
acosmicflamingo
force-pushed
the
fix-uinavigationcontrollerdelegate-forwarding-for-real
branch
from
91d4943 to
6883e9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was lots of discussion in #311 on how to address the issue with
PathDelegatebeing registered as NavigationStackController'ssuper.delegateearlier than expected, so here's a PR that takes @tgrapperon 's changes, adds a purple run-time warning letting users know to set their delegate in theinit, and an update to the test that addresses this issue.