Skip to content

Refactor temporary trigger touch APIs to be more flexible. #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 8, 2025
Merged

Refactor temporary trigger touch APIs to be more flexible. #202

merged 4 commits into from
Oct 8, 2025
+284 −192

Conversation

stephencelis
Copy link
Member 

// Before:
Reminder.createTemporaryTrigger(afterUpdateTouch: { $0.position += 1 })
// After:
Reminder.createTemporaryTrigger(after: .update { $0.position += 1 })

// Before:
Reminder.createTemporaryTrigger(afterInsertTouch: \.createdAt)
// After:
Reminder.createTemporaryTrigger(after: .insert(touch: \.createdAt))

Notably, the of and when parameters are now available to these helpers so that they can be scoped to certain fields/conditions.

@stephencelis
Temporary trigger improvements
426219f 
The "touch" helpers have been moved from statics on the table type to
statics on the operation type so that additional customization (like
`on` and `when`) can be surfaced.
@stephencelis
wip
8f0fa74
@stephencelis
wip
dedf015
@stephencelis
wip
1ba48d6
@stephencelis stephencelis requested a review from mbrandonw October 6, 2025 21:20
stephencelis
stephencelis commented Oct 6, 2025
View reviewed changes
Sources/StructuredQueriesSQLiteCore/Internal/Deprecations.swift
Comment on lines +6 to +11
extension Table {
@available(
*,
deprecated,
message: "Prefer 'createTemporaryTrigger(after: .update(touch:))', instead"
)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth soft-deprecating, or is the surface minimal enough to push folks to the new APIs sooner?

@stephencelis stephencelis merged commit abb5084 into main Oct 8, 2025
3 checks passed
@stephencelis stephencelis deleted the touch-when branch October 8, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbrandonw mbrandonw mbrandonw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephencelis @mbrandonw