Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Delete validator pod if stuck during E2E test #415

Merged
merged 4 commits into from
Mar 18, 2024
Merged

Conversation

okdas
Copy link
Member

@okdas okdas commented Mar 7, 2024

Summary

Human Summary

Delete stuck validator Pod during E2E test.

AI Summary

reviewpad:summary

Issue

DevNets now use a new helm chart that provisions validators as StatefulSets. As a result, if such validator had unsuccessful deployment, it won't be upgraded to the newer version due to StatefulSet uptime guarantees. We need to kill that pod, so StatefulSet controller creates a new one with correct image.

Type of change

Select one or more:

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Documentation
  • Other (specify)

Testing

  • Run all unit tests: make go_develop_and_test
  • Run E2E tests locally: make test_e2e
  • Run E2E tests on DevNet: Add the devnet-test-e2e label to the PR. This is VERY expensive, only do it after all the reviews are complete.

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have performed a self-review of my own code
  • I have commented my code, updated documentation and left TODOs throughout the codebase

@okdas okdas added infra Infra or tooling related improvements, additions or fixes push-image CI related - pushes images to ghcr.io devnet devnet-test-e2e labels Mar 7, 2024
@okdas okdas added this to the Shannon TestNet milestone Mar 7, 2024
@okdas okdas self-assigned this Mar 7, 2024
Copy link

github-actions bot commented Mar 7, 2024

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks. If you just created a pull request, you might need to push another commit to produce a container image DevNet can utilize to spin up infrastructure. You can use make trigger_ci to push an empty commit.

Copy link

github-actions bot commented Mar 7, 2024

The image is going to be pushed after the next commit. You can use make trigger_ci to push an empty commit. If you also want to run an E2E test, please add devnet-test-e2e label.

@okdas okdas marked this pull request as ready for review March 12, 2024 00:01
@okdas okdas requested a review from Olshansk March 12, 2024 00:02
.github/workflows-helpers/run-e2e-test.sh Outdated Show resolved Hide resolved
.github/workflows-helpers/run-e2e-test.sh Outdated Show resolved Hide resolved
@okdas okdas requested a review from Olshansk March 13, 2024 22:17
@okdas okdas merged commit a94ffd3 into main Mar 18, 2024
9 checks passed
bryanchriswhite added a commit that referenced this pull request Mar 22, 2024
* pokt/main:
  [LocalNet] Fix/localnet regenesis (#424)
  [CI] Delete validator pod if stuck during E2E test (#415)
  Fixing reletive link in documentation
  [Docs] Add code review guidelines & developer tips (#426)
  [Quick change] Bump default gas limit (#431)
bryanchriswhite added a commit that referenced this pull request Mar 22, 2024
* feat/proof-validation:
  Offline review of 406
  [LocalNet] Fix/localnet regenesis (#424)
  [CI] Delete validator pod if stuck during E2E test (#415)
  Fixing reletive link in documentation
  [Docs] Add code review guidelines & developer tips (#426)
  [Quick change] Bump default gas limit (#431)
  chore: Fix unit tests and ring client removal consideration
  chore: Remove pubkey client
  chore: Add missing change requests
  chore: Address review change requests
  Update pull_request_template.md
  Update pull_request_template.md
  [Cleanup] Wrap errors consistently via error types. (#422)
  [LocalNet] Allow to scale up actors (#414)
  [Test] Replace time waiting with message submission waiting (#418)
  Remove accidentally added config files (#420)
  fix: Ignore externally initiated transactions (#407)
  [Bug] Address go-routines leak (#410)
@bryanchriswhite bryanchriswhite removed push-image CI related - pushes images to ghcr.io devnet-test-e2e labels May 16, 2024
@github-actions github-actions bot removed the devnet label May 16, 2024
@Olshansk Olshansk deleted the delete-pod-during-ci branch May 29, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Infra or tooling related improvements, additions or fixes
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants