-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Release artifacts job: binaries and containers #523
Conversation
The image is going to be pushed after the next commit. You can use |
The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks. If you just created a pull request, you might need to push another commit to produce a container image DevNet can utilize to spin up infrastructure. You can use |
on: | ||
push: | ||
tags: | ||
- "v*.*.*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested this on the push
trigger, but we don't have a good way to test the release creation from tag. Let's create the first tag after this is merged to test this CI job fully.
@Olshansk Upgrade to 1.22 was important for integration with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one non-blocking question!
|
||
USER pocket | ||
|
||
ENTRYPOINT ["poktrolld"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the poktrolld binary the entrpoint?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the poktrolld binary the entrpoint?
glad you asked.
It allows to easy set up a shell alias to use poktrolld
from docker without installing the binary on the machine. I'll showcase this in the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#PUC
# poktrolld is the entrypoint to allow easily setting up a shell alias to use poktrolld from docker without installing the binary on the machine. I'll showcase this in the docs.
ENTRYPOINT ["poktrolld"]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@okdas ☝️
* pokt/main: [CI] Release artifacts job: binaries and containers (#523)
…cept * pokt/main: [CI] Release artifacts job: binaries and containers (#523)
Summary
Provides binaries for releases and production-ready container images.
Issue
Type of change
Select one or more:
Testing
Documentation changes (only if making doc changes)
make docusaurus_start
; only needed if you make doc changesLocal Testing (only if making code changes)
make go_develop_and_test
make test_e2e
PR Testing (only if making code changes)
devnet-test-e2e
label to the PR.make trigger_ci
if you want to re-trigger tests without any code changesSanity Checklist