[Tilt] Enable rest service by default in Tilt #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
red-0ne
added
testing
Olshansk
approved these changes
Sep 4, 2024
Olshansk
pushed a commit
that referenced
this pull request
Sep 4, 2024
## Summary Enable the `rest` service by default in Tilt ## Issue Since the `rest` service is used in E2E tests, it should be enabled by default to avoid non-edited `localnet_config.yaml` files to succeed E2E tests.  ## Type of change Select one or more from the following: - [ ] New feature, functionality or library - [ ] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [x] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Testing - [ ] **Documentation**: `make docusaurus_start`; only needed if you make doc changes - [ ] **Unit Tests**: `make go_develop_and_test` - [ ] **LocalNet E2E Tests**: `make test_e2e` - [ ] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR. ## Sanity Checklist - [ ] I have tested my changes using the available tooling - [ ] I have commented my code - [ ] I have performed a self-review of my own code; both comments & source code - [ ] I create and reference any new tickets, if applicable - [ ] I have left TODOs throughout the codebase, if applicable
bryanchriswhite
added a commit
that referenced
this pull request
Sep 5, 2024
…ke-transfer * pokt/main: [Relay Mining] Use per-service difficulty in the relayer (#745) [Tilt] Enable rest service by default in Tilt (#793) [Docs] Minor doc updates across the board (#792) build(deps): bump webpack from 5.89.0 to 5.94.0 in /docusaurus (#775) [Docs] Tokenomics Documentation (#750) fix: ensure stable_marshaler_all option on all proto files (#772) build(deps): bump micromatch from 4.0.5 to 4.0.8 in /docusaurus (#774) [Tooling] Add `protocheck` CLI tool (#770) Update `adding_params.md` to use `ignite` (#764) [Docs] Cleanup & Deprecation (#766)
bryanchriswhite
added a commit
that referenced
this pull request
Sep 5, 2024
…actor/transfer-msg_period-param * issues/657/feat/app-stake-transfer: chore: regenerate protobufs [Relay Mining] Use per-service difficulty in the relayer (#745) [Tilt] Enable rest service by default in Tilt (#793) [Docs] Minor doc updates across the board (#792) build(deps): bump webpack from 5.89.0 to 5.94.0 in /docusaurus (#775) [Docs] Tokenomics Documentation (#750) fix: ensure stable_marshaler_all option on all proto files (#772) build(deps): bump micromatch from 4.0.5 to 4.0.8 in /docusaurus (#774) [Tooling] Add `protocheck` CLI tool (#770) Update `adding_params.md` to use `ignite` (#764) [Docs] Cleanup & Deprecation (#766)
bryanchriswhite
added a commit
that referenced
this pull request
Sep 5, 2024
…ues/657/chore/app-transfer-period * issues/657/refactor/transfer-msg_period-param: chore: regenerate protobufs chore: regenerate protobufs fix: failing test chore: regenerate protobufs Revert "refactor: rename param to application_transfer_and_unboding_period_sessions" [Relay Mining] Use per-service difficulty in the relayer (#745) [Tilt] Enable rest service by default in Tilt (#793) [Docs] Minor doc updates across the board (#792) build(deps): bump webpack from 5.89.0 to 5.94.0 in /docusaurus (#775) [Docs] Tokenomics Documentation (#750) fix: ensure stable_marshaler_all option on all proto files (#772) build(deps): bump micromatch from 4.0.5 to 4.0.8 in /docusaurus (#774) [Tooling] Add `protocheck` CLI tool (#770) Update `adding_params.md` to use `ignite` (#764) [Docs] Cleanup & Deprecation (#766)
okdas
pushed a commit
that referenced
this pull request
Nov 14, 2024
## Summary Enable the `rest` service by default in Tilt ## Issue Since the `rest` service is used in E2E tests, it should be enabled by default to avoid non-edited `localnet_config.yaml` files to succeed E2E tests.  ## Type of change Select one or more from the following: - [ ] New feature, functionality or library - [ ] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [x] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Testing - [ ] **Documentation**: `make docusaurus_start`; only needed if you make doc changes - [ ] **Unit Tests**: `make go_develop_and_test` - [ ] **LocalNet E2E Tests**: `make test_e2e` - [ ] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR. ## Sanity Checklist - [ ] I have tested my changes using the available tooling - [ ] I have commented my code - [ ] I have performed a self-review of my own code; both comments & source code - [ ] I create and reference any new tickets, if applicable - [ ] I have left TODOs throughout the codebase, if applicable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enable the
restservice by default in TiltIssue
Since the
restservice is used in E2E tests, it should be enabled by default to avoid non-editedlocalnet_config.yamlfiles to succeed E2E tests.Type of change
Select one or more from the following:
consensus-breakinglabel if so. See [Infra] Automatically add theconsensus-breakinglabel #791 for detailsTesting
make docusaurus_start; only needed if you make doc changesmake go_develop_and_testmake test_e2edevnet-test-e2elabel to the PR.Sanity Checklist