sqlparser/logictest: add datadriven testing #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a sqlparse package with the initial functionality to parse SQL into FrostDB logical plans. Distinct, Aggregate and Filters are all supported. SQL is parsed using TiDB's standalone MySQL parser. Given the simplicity of the SQL we support, there are no variant-specific corners we're painting ourselves into yet.
This commit adds a simple datadriven logic testing framework with the ability to create tables, insert data, and query data. Some existing distinct and aggregation tests have been copied and modified to use the new testing framework. The advantage of a framework like this is that it makes tests easier to understand and write, simplifying bug resolution and lowering the bar to writing tests.
asubiotto
force-pushed
the
alfonso-datadriven
branch
from
e51ac04
to
dd0149f
Compare
brancz
approved these changes
Sep 26, 2022
|
TFTR! Definitely take it piece by piece. This is more of a POC that copies some tests. Hopefully new tests will use this and we'll port existing tests over little by little (maybe on Friday). |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds datadriven testing to FrostDB, which is the ability to write text files with simple commands to create tables, insert data, query data, and specify expected results. To support expressive querying of data, this PR also adds experimental SQL support to FrostDB. This is done by leveraging TiDB's standalone MySQL parser and converting the resulting AST to a FrostDB query.