WIP nipypification of pydeface #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
reviewed
Feb 15, 2019
| warped_mask = list(deface_res.nodes())[6].result.otputs[0] | ||
| template_reg_mat = list(deface_res.nodes())[6].result.otputs[2] | ||
| unclean_mask = args.infile.replace('.gz', '').replace('.nii', '_pydeface_mask.nii.gz') | ||
| unclean_mat = args.infile.replace('.gz','').replace('.nii', '_pydeface.mat') |
There was a problem hiding this comment.
Whoops, thanks for catching that, I'd tested the utilities, but not the main interface.
There was a problem hiding this comment.
Got that working, in addition to misspelling, it needed to be .outputs.out_file, but I'd love to know if there's a better way to do this.
Co-Authored-By: Shotgunosine <adenosine@gmail.com>
|
This will need significant rewriting, so I'm going to close this. Please reopen if you do want to try again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried to overhaul pydeface so that the utility functions create and manipulate nipype workflows.
TODO:
deface_node and follower_node are writing directly to output directories and not writing to their working directories and then moving final outputs from the datasink to an appropriate location