Skip to content

Conversation

ylyangtw
Copy link
Contributor

No description provided.

navarroc and others added 3 commits June 30, 2025 08:40
* Update TITLE-I endpoints to use data from 2014 to 2023 as the default.

* Update CHANGELOG.md

Moved entry to unreleased section.
* Rename totalCounts with totalRecipientCount

* rename title I totalRecipients to totalRecipientCount
@ylyangtw ylyangtw linked an issue Jul 30, 2025 that may be closed by this pull request
CHANGELOG.md Outdated
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## [Unreleased]
## [0.24.0] - 2025-07-31

Copy link
Contributor

@pengyin-shan pengyin-shan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion: at the end of the Front-end CHANGELOG, there’s a section that allows users to compare versions, like this:

[1.11.0]: https://github.com/policy-design-lab/pdl-frontend/compare/1.10.0...1.11.0  
[1.10.0]: https://github.com/policy-design-lab/pdl-frontend/compare/1.9.0...1.10.0  
[1.9.0]: https://github.com/policy-design-lab/pdl-frontend/compare/1.8.0...1.9.0  
[1.8.0]: https://github.com/policy-design-lab/pdl-frontend/compare/1.7.0...1.8.0  
...

Do we want to add something similar at the end of this API CHANGELOG? This will make it easier to navigate the differences between each release

@pengyin-shan
Copy link
Contributor

Also, @ylyangtw @sandeep-ps , in the last release, we have
Screenshot 2025-07-31 at 1 22 22 PM
but it is not in this release PR. Should this be updated as well? Sorry if I missed anything since I'm not very familar w/ backend rules.

@sandeep-ps
Copy link
Member

sandeep-ps commented Jul 31, 2025

Yes, we need the version change (thanks for catching that) and the entry at the end of CHANGELOG.

Ref: #337 (comment)

@ylyangtw
Copy link
Contributor Author

https://github.com/policy-design-lab

Sounds good. Where do you add it? I could not find it in frontend changelog https://github.com/policy-design-lab/pdl-frontend/blob/release-1.11.0/CHANGELOG.md

@sandeep-ps
Copy link
Member

Sounds good. Where do you add it? I could not find it in frontend changelog https://github.com/policy-design-lab/pdl-frontend/blob/release-1.11.0/CHANGELOG.md

Please use this PR as reference. Please see the change at the bottom of the CHANGELOG.

@ylyangtw
Copy link
Contributor Author

Thanks for review @sandeep-ps @pengyin-shan I have addressed all feedbacks!

Copy link
Member

@sandeep-ps sandeep-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. I will approve.

@ylyangtw ylyangtw merged commit 63cee7e into main Jul 31, 2025
2 checks passed
@ylyangtw ylyangtw deleted the release-0.24.0 branch July 31, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release 0.24.0
4 participants