Skip to content

Change All Programs Total key format #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 20, 2025
Merged

Change All Programs Total key format #422

merged 4 commits into from
Aug 20, 2025

Conversation

ylyangtw
Copy link
Contributor

To test this PR, please test this api PR policy-design-lab/pdl-api#340 together

@ylyangtw ylyangtw linked an issue Aug 14, 2025 that may be closed by this pull request
[TASK] Change All Programs Total key format #421
Closed
pengyin-shan
pengyin-shan approved these changes Aug 20, 2025
View reviewed changes
Copy link
Collaborator

@pengyin-shan pengyin-shan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The landing page map is functioning correctly (aside from the data mismatch issue currently being discussed in Slack). I’m approving this PR since it restores front-end functionality, but please also refer to the data discussion.

navarroc
navarroc approved these changes Aug 20, 2025
View reviewed changes
Copy link
Contributor

@navarroc navarroc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, checked running this locally and compared with prod using the production DB and API PR and all data matches.

@ylyangtw ylyangtw merged commit abe63d9 into develop Aug 20, 2025
5 checks passed
@ylyangtw ylyangtw deleted the 421-task-change-all-programs-total-key-format branch August 20, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navarroc navarroc navarroc approved these changes

@pengyin-shan pengyin-shan pengyin-shan approved these changes

@sandeep-ps sandeep-ps Awaiting requested review from sandeep-ps

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TASK] Change All Programs Total key format
3 participants
@ylyangtw @navarroc @pengyin-shan