Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Executing the Utility::batch_all() method via XCM #112

Closed
ark930 opened this issue Dec 6, 2023 · 2 comments · Fixed by #172
Closed

Executing the Utility::batch_all() method via XCM #112

ark930 opened this issue Dec 6, 2023 · 2 comments · Fixed by #172

Comments

@ark930
Copy link

ark930 commented Dec 6, 2023

This RP paritytech/polkadot-sdk#1303 has removed restrictions related to SafeCallFilter, allowing actions such as sending XCM messages from Parachain and executing the Utility::batch_all() method in the Relaychain. However, we've noticed that SafeCallFilter is still retained after the separation of polkadot-runtime and kusama-runtime from the polkadot-sdk into this new project
Was this an oversight in updating? I believe cross-chain invocations of Utility::batch_all() are a common practice and should not be restricted.
@bkchr
Copy link
Contributor

bkchr commented Jan 30, 2024

CC @ggwpez

@ggwpez
Copy link
Member

ggwpez commented Jan 30, 2024

Good catch!
The file was correctly imported at tag v1.1.0-rc2 and the Filter was still present there in MR #28.
It think there was a period where we had already imported the runtimes but did not yet delete them in the SDK. We need to re-apply these changes.

@ggwpez ggwpez mentioned this issue Jan 30, 2024
Merged
fellowship-merge-bot bot added a commit that referenced this issue Feb 2, 2024
@ggwpez @fellowship-merge-bot
@bkchr @joepetrowski
Reapply changes since v1.1.0-rc2 import (#172)
9ce1bbb 
We imported the runtimes into this repo at tag
[`v1.1.0-rc2`](https://github.com/paritytech/polkadot-sdk/commits/v1.1.0-rc2/)
but still merged stuff until they got removed in
[#1731](paritytech/polkadot-sdk#1731).
This re-applies all changes in that commit range
[`v1.1.0-rc2..bf90cb0b`](paritytech/polkadot-sdk@v1.1.0-rc2...bf90cb0)
checked in the SDK with
`git log v1.1.0-rc2..bf90cb0b -- polkadot/runtime/`. Closes
#112

Most changes got applied as part of
#56, but two were
missing:
- paritytech/polkadot-sdk#1303
- <s>https://github.com/paritytech/polkadot-sdk/pull/1476</s> (reverted)

<s>One [open
Q](#67 (comment))
since there was a difference between
[#1291](paritytech/polkadot-sdk#1291) and
#67.</s>

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: fellowship-merge-bot[bot] <151052383+fellowship-merge-bot[bot]@users.noreply.github.com>
Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
@ark930 ark930 closed this as completed Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reapply changes since v1.1.0-rc2 import polkadot-fellows/runtimes
3 participants
@ark930 @bkchr @ggwpez