Upgrade from v1.2 to v1.3 #87
Conversation
[requires migration. onchain or offchain?]
[do we need to upgrade?]
[upgrade required?]
[have no idea - Polkadot, Kusama, ...?]
…ks compilation?)
adapt paritytech/polkadot-sdk#1234 (UMP price for delivery + benchmarks compilation)
system-parachains/asset-hubs/asset-hub-kusama/src/xcm_config.rs
Outdated
Show resolved
Hide resolved
system-parachains/asset-hubs/asset-hub-kusama/src/xcm_config.rs
Outdated
Show resolved
Hide resolved
system-parachains/asset-hubs/asset-hub-polkadot/src/xcm_config.rs
Outdated
Show resolved
Hide resolved
system-parachains/asset-hubs/asset-hub-polkadot/src/xcm_config.rs
Outdated
Show resolved
Hide resolved
|
Looks like @svyatonik maybe a rebase to re-trigger the bot check? or anyone with access to rebase from GH PR GUI. |
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Head branch was pushed to by a user without write access
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
@acatangiu Pushed some commits - still required :/ |
|
Maybe that's the reason: #87 (comment). So if anything is pushed, then we need reviews again maybe? |
I'm currently investigating this. It is weird, it doesn't get all the reviews and I'm not sure on why 🤔. It is only getting 4 reviews |
|
For some reason the API is not registering most of the reviews. You can try it in your own terminal This returns a JSON which
I found the issue. It is a problem with pagination. The api returns the first 30 reviews, and there are more than that in this PR (comments & request for change also count). I created paritytech/review-bot#102 to fix it. It will be my priority. |
…pgrade-from-2_0-to-3_0
|
/merge |
fellowship-merge-bot
bot
merged commit 4e4da08
into
polkadot-fellows:main
|
Enabled Available commands
For more information see the documentation |
…vel (#2422) As suggested in this thread: polkadot-fellows/runtimes#87 (comment) We already have the `IsChildSystemParachain`, which may be used at relay chain, but it can't be used at a parachain level. So let's use `AllSiblingSystemParachains` for that. I was thinking about `AllSystemParachains`, but it may cause wrong impression that it can be used at a relay chain level. --------- Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
Opening PR mostly for visibility - I expect #56 to be finished before, which would bump everything to v1.2 and then I'll convert this PR to v1.2 -> v1.3. In its current state, this PR does v1.0 -> v1.3 bump, although I've only been looking at v1.2 -> v1.3 changelog, so everything else just compiles.
TODOs left in this PR (which I'd like to address after #56 is finished):
[cargo upgrade --pinned --incompatible](https://github.com/polkadot-fellows/runtimes/commit/8df27a586b598d2f783b53cd62b127b8f8ac846a)and only leave sdk crates bump;(maybe worth a separate PR) there's a lot of unused weight files in this repo - I'd like to remove itwill do it in a separate PR - tracked here: https://github.com/svyatonik/runtimes/tree/remove-unused-weight-files@liamaharon Can you, please, confirm that the paritytech/polkadot-sdk#1344 was necessary only for sdk CI fixes - that PR caught my eye when I was looking at 1.3 CHANGELOG and I was wondering if we need to do the same for Polkadot, Kusama and system parachains?