Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FRAME: Revamp Preimage pallet to use Consideration #1363

Merged
merged 55 commits into from Sep 17, 2023
Merged

FRAME: Revamp Preimage pallet to use Consideration #1363

merged 55 commits into from Sep 17, 2023

Conversation

gavofyork
Copy link
Member

@gavofyork gavofyork commented Sep 2, 2023 •
edited by ggwpez

Make Preimage pallet use Consideration instead of handling deposits directly.

Other half of paritytech/substrate#13666.
Depends/based on #1361.

Script for the lazy migration that should be run manually once: migrate-preimage-lazy.py.

TODO

  • Migration code.

@gavofyork gavofyork added the T2-pallets This PR/Issue is related to a particular pallet. label Sep 2, 2023
@gavofyork gavofyork changed the title Frame: Revamp Preimage pallet to use Consideration FRAME: Revamp Preimage pallet to use Consideration Sep 2, 2023
@gavofyork gavofyork marked this pull request as ready for review September 3, 2023 11:14
gavofyork and others added 9 commits September 6, 2023 12:51
@gavofyork
Fix for new API
f773a55
@gavofyork
Remove type params from preimage
7aeae8c
@ggwpez
Make benches compile
ae6d315 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Expose ensure_updated
45b4160 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Fixup mocks
3479c19 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Fix more mocks
22e3fcf 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
More weight fixes
27f5885 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Clippy
6167e4a 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
More clippy
c20a5f5 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Copy link
Member

ggwpez commented Sep 6, 2023

bot bench substrate-pallet --pallet=pallet_preimage

@command-bot
Copy link

command-bot bot commented Sep 6, 2023 •
edited

@ggwpez https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3593250 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_preimage. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 2-0ac52503-4b00-40f4-9768-a8a9466dc8ce to cancel this command or bot cancel to cancel all commands in this pull request.

".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…
2582232 
…=dev --target_dir=substrate --pallet=pallet_preimage
@command-bot
Copy link

command-bot bot commented Sep 6, 2023

@ggwpez Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_preimage has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3593250 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3593250/artifacts/download.

franciscoaguirre
franciscoaguirre approved these changes Sep 11, 2023
View reviewed changes
substrate/frame/preimage/src/lib.rs Outdated Show resolved Hide resolved
substrate/frame/preimage/src/lib.rs Outdated Show resolved Hide resolved
substrate/frame/preimage/src/lib.rs Outdated Show resolved Hide resolved
substrate/frame/preimage/src/lib.rs Show resolved Hide resolved
substrate/frame/preimage/src/lib.rs Show resolved Hide resolved
substrate/frame/preimage/src/lib.rs Outdated Show resolved Hide resolved
substrate/frame/preimage/src/tests.rs Outdated Show resolved Hide resolved
gavofyork and others added 5 commits September 12, 2023 13:18
@gavofyork @franciscoaguirre
Update substrate/frame/preimage/src/lib.rs
fdbacb1 
Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>
@gavofyork @franciscoaguirre
Update substrate/frame/preimage/src/lib.rs
c2097b2 
Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>
@gavofyork @franciscoaguirre
Update substrate/frame/preimage/src/tests.rs
97542d2 
Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>
@gavofyork
Minor tweaks
2ed225d
@gavofyork
Merge branch 'gav-consideration-preimage' of github.com:paritytech/po…
095a56d 
…lkadot-sdk into gav-consideration-preimage
@gavofyork gavofyork requested a review from a team September 14, 2023 14:55
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3698484

@gavofyork gavofyork merged commit d787269 into master Sep 17, 2023
107 of 109 checks passed
@gavofyork gavofyork deleted the gav-consideration-preimage branch September 17, 2023 11:19
@muharem muharem mentioned this pull request Oct 5, 2023
Merged
1 task
@kiltbot kiltbot mentioned this pull request Oct 19, 2023
Open
@jasl jasl mentioned this pull request Oct 26, 2023
Merged
svyatonik added a commit to svyatonik/runtimes that referenced this pull request Nov 3, 2023
@svyatonik
adapt paritytech/polkadot-sdk#1363
b8f7a8d 
[requires migration. onchain or offchain?]
@xlc xlc mentioned this pull request Nov 15, 2023
Merged
3 tasks
@ahmadkaouk ahmadkaouk mentioned this pull request Nov 16, 2023
Closed
bkchr added a commit to polkadot-fellows/runtimes that referenced this pull request Nov 20, 2023
@muharem @ggwpez
@bkchr @joepetrowski
upgrade to v1.2 (#56)
bdcd039 
In the PR we bump versions for all dependacy crates from `polkadot-sdk`
and apply all required changes

Changes:
- `parachains_runtime_api_impl` `v5` -> `v7`,
  - from paritytech/polkadot-sdk#1543;
- `Consideration` setup for preimage pallet instances,
  - from  paritytech/polkadot-sdk#1363;
- `experimental` feature removed for `pallet-society`, `pallet-xcm`,
`runtime-common` crates,
  - from paritytech/polkadot-sdk#1503;
- `pallet_election_provider_multi_phase::Config::SignedDepositBase` set
to `GeometricDepositBase`,
  - from paritytech/polkadot-sdk#1547;
- support `open_outbound_hrmp_channel_for_benchmarks_or_tests` func
rename,
  - from paritytech/polkadot-sdk#1422;
- missing weight functions added for `runtime_parachains_hrmp` and
`pallet_preimage`;

TODO:
- [x] Deleted the Copy&paste para scheduler migration from
#26 in
b666613. This should be applied in the
next runtime upgrade, but i did not properly check yet.

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
@Polkadot-Forum
Copy link

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/polkadot-release-analysis-v1-2-0/4451/2

This was referenced Jan 4, 2024
Closed
Closed
@dnjscksdn98 dnjscksdn98 mentioned this pull request Jan 12, 2024
Merged
13 tasks
@TarikGul TarikGul mentioned this pull request Feb 29, 2024
Merged
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
@gavofyork @ggwpez
@franciscoaguirre @kianenigma
FRAME: Revamp Preimage pallet to use Consideration (paritytech#1363)
bc16714 
Make Preimage pallet use Consideration instead of handling deposits
directly.

Other half of paritytech/substrate#13666.
Depends/based on paritytech#1361.

Script for the lazy migration that should be run manually once:
[migrate-preimage-lazy.py](https://github.com/ggwpez/substrate-scripts/blob/master/migrate-preimage-lazy.py).

## TODO

- [x] Migration code.

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: command-bot <>
Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
@Dinonard Dinonard mentioned this pull request Mar 28, 2024
Merged
@ukint-vs ukint-vs mentioned this pull request Apr 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franciscoaguirre franciscoaguirre franciscoaguirre approved these changes

@ggwpez ggwpez ggwpez approved these changes

Assignees
No one assigned
Labels
T2-pallets This PR/Issue is related to a particular pallet.
Projects
Runtime / FRAME
Status: Done
Security Audit (PRs) - SRLabs
Status: Audited
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gavofyork @ggwpez @paritytech-cicd-pr @Polkadot-Forum @franciscoaguirre