feat: topological sort for releases #1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TarikGul
changed the title
polkadot-js-bot
approved these changes
May 6, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The following adds topological sorting for a workspace and it's corresponding packages. Unfortunately not all
@polkadot/*are able to be ordered with full topological integrity as some repos have circular deps. That being said this is one avenue to help the releases be more fault tolerant and will help avoid situations like: polkadot-js/api#5841Circular dependencies
The current algorithm deals with circular dependencies by adding them to the end of the sorted vector. The order in which it adds them is based on the length of their vertices. This is from least to greatest.
closes: #1139