Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug datepicker with format changed #247

Closed
1 of 2 tasks
iNeoO opened this issue Jul 18, 2019 · 12 comments
Closed
1 of 2 tasks

Bug datepicker with format changed #247

iNeoO opened this issue Jul 18, 2019 · 12 comments

Comments

@iNeoO
Copy link

iNeoO commented Jul 18, 2019

Is this a BUG REPORT or FEATURE REQUEST?:

  • BUG
  • FEATURE

What happened:
When changing date format, date picker bug

What did you expect to happen:
get the good date in date picker

How to reproduce it (as minimally and precisely as possible):
in settings change date format
go to date picker in the edit ticket form

Anything else we need to know?:
settings
captured
Gif of the bug
captured

Environment:

  • Trudesk Version: 299edb4 : 1.0.15
  • OS (e.g. from /etc/os-release): ubuntu 18.04.2 LTS (Bionic Beaver)
  • Node.JS Version: 6.7.0
  • MongoDB Version: v3.6.12
  • Is this hosted on cloud.trudesk.io: no
@polonel
Copy link
Owner

polonel commented Jul 26, 2019

Are you referring to the rendering issue where the date renders the default format and then quickly switches to the customized format?

@iNeoO
Copy link
Author

iNeoO commented Jul 26, 2019

Nop, picking 4 January change the date to 1 may in the date picker

@stale
Copy link

stale bot commented Aug 5, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Aug 5, 2019
@iNeoO
Copy link
Author

iNeoO commented Aug 5, 2019

Up

@stale stale bot removed the wontfix label Aug 5, 2019
@polonel polonel added the bug label Aug 5, 2019
@jackd942
Copy link

jackd942 commented Aug 6, 2019

I can confirm this on our end as well. Although in our case, the date that gets stored to mongo appears to be one day off...ie select 8/6/2019 saves 8/5/2019. UI for the date picker seems to have some strange behavior as well...if selecting 8/6, it re-renders to 8/5, but if you keep changing it, 8/6 will eventually stick, although 8/5 still gets sent to the db.

@polonel
Copy link
Owner

polonel commented Aug 6, 2019 via email

@jackd942
Copy link

jackd942 commented Aug 6, 2019

Just double checked to make sure my Timezone was set correctly and it is. So I guess the logic in the component is not taking the timezone setting into account?

@polonel
Copy link
Owner

polonel commented Aug 6, 2019 via email

@jackd942
Copy link

jackd942 commented Aug 6, 2019

Actually I'm not sure if that is the case. We are -5 and still seeing the behavior I described above. It is currently 11:45am 8/6 here and utc is 4:45 8/6. We still see that behavior, so I think that may rule that out.

polonel added a commit that referenced this issue Aug 8, 2019
@polonel
Copy link
Owner

polonel commented Aug 8, 2019

@iNeoO @jackd942
I pushed a fix (hopefully) to develop. If you guys don't mind giving it a test on your environments.

@iNeoO
Copy link
Author

iNeoO commented Aug 8, 2019

thx, that's fine for me ! (we can close)

@stale
Copy link

stale bot commented Aug 18, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Aug 18, 2019
@stale stale bot closed this as completed Aug 23, 2019
polonel added a commit that referenced this issue Sep 8, 2019
## [1.0.16](v1.0.15...v1.0.16) (2019-09-08)

### Bug Fixes

* **datepicker:** [#247](#247) ([d51e341](d51e341))
* **mailcheck:** [#251](#251) - Not creating ticket due to invalid group ([1d97104](1d97104))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants