Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ciphers use default nodejs ciphers #595

Merged
merged 2 commits into from
Jun 20, 2023

Conversation

mtudury
Copy link
Contributor

@mtudury mtudury commented Feb 23, 2023

Hello !

I'm testing trudesk for a nonprofit sport association homehosted, and i found i was not able to send mails until i fixed this

I dived into nodemailer documentation (https://nodemailer.com/smtp/) that linked to nodejs (v16) one ( https://nodejs.org/docs/latest-v16.x/api/tls.html#tls_class_tls_tlssocket )
I found that :

  • SSLv3 is a protocol not a cipher
  • to get list of ciphers
node

console.log(tls.getCiphers());

list all available ciphers.

Hope this can help.

Thanks for making trudesk

Regards

Matthieu

@polonel polonel changed the base branch from master to develop March 11, 2023 19:01
@polonel polonel merged commit b6200ca into polonel:develop Jun 20, 2023
@polonel
Copy link
Owner

polonel commented Jun 22, 2023

🎉 This PR is included in version 1.2.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants